ACLE/SIMD32: add ssub8 and usub8
#696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `ssub8` and `usub8` - bump instruction limit to 29
|
Travis is green. AppVeyor failure is unrelated and looks like a well known issue. |
|
@paoloteti heads up: I'm waiting for this PR upstream to be merged before adding more features to stdsimd: rust-lang/rust#58675 since we need that to port libstd to the 2018 edition. Once that is done, I'll start merging other PRs as well (feel free to submit more PRs implementing the other APIs or to add those to this one in the meantime). Also I would prefer if someone more familiar with ACLE like @japaric @Amanieu or @parched would review the PRs related to these. |
|
LGTM |
Amanieu
reviewed
Feb 24, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssub8andusub8cc @japaric