Skip to content

Add GCC run to intrinsic-test#2125

Merged
folkertdev merged 2 commits into
rust-lang:mainfrom
sayantn:intrinsic-test-gcc
May 24, 2026
Merged

Add GCC run to intrinsic-test#2125
folkertdev merged 2 commits into
rust-lang:mainfrom
sayantn:intrinsic-test-gcc

Conversation

@sayantn
Copy link
Copy Markdown
Contributor

@sayantn sayantn commented May 20, 2026

Let's try to add a GCC run to intrinsic-test now that it is much easier to do. Also add a ICX run for x86_64 because why not!

Currently disables the GCC run on ARM32, because GCC has a lot of miscompilations and missing intrinsics in ARM32.

Also, weirdly exactly 6 intrinsics have rounding errors in release mode, in all 3 compilers!

@sayantn sayantn force-pushed the intrinsic-test-gcc branch 7 times, most recently from ccd8c12 to af4c94a Compare May 21, 2026 14:56
@sayantn sayantn marked this pull request as ready for review May 21, 2026 14:58
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 21, 2026

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Amanieu, @adamgemmell, @davidtwco, @folkertdev, @sayantn
  • @Amanieu, @adamgemmell, @davidtwco, @folkertdev, @sayantn expanded to Amanieu, adamgemmell, davidtwco, folkertdev, sayantn
  • Random selection from Amanieu, adamgemmell, davidtwco, folkertdev

@sayantn sayantn force-pushed the intrinsic-test-gcc branch from af4c94a to af99dd8 Compare May 21, 2026 18:26
Comment thread ci/intrinsic-test.sh Outdated
Comment thread crates/intrinsic-test/src/arm/mod.rs Outdated
Comment thread crates/intrinsic-test/src/common/cli.rs Outdated
@sayantn sayantn force-pushed the intrinsic-test-gcc branch 3 times, most recently from 3c8db90 to 009f212 Compare May 24, 2026 14:12
@rustbot

This comment has been minimized.

@sayantn sayantn force-pushed the intrinsic-test-gcc branch from 009f212 to e6f070d Compare May 24, 2026 14:55
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 24, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@folkertdev folkertdev enabled auto-merge May 24, 2026 15:02
@folkertdev folkertdev added this pull request to the merge queue May 24, 2026
Merged via the queue into rust-lang:main with commit 329aedd May 24, 2026
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants