Refactor avx512bw #1602
Merged
Refactor avx512bw #1602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
TDecking
force-pushed
the
avx512bw
branch
11 times, most recently
from
5ff9ecd to
2896bd0
Compare
|
☔ The latest upstream changes (presumably 3dd9579) made this pull request unmergeable. Please resolve the merge conflicts. |
Amanieu
reviewed
Jul 6, 2024
crates/core_arch/src/x86/avx512bw.rs
Outdated
| #[target_feature(enable = "avx512bw")] | ||
| #[unstable(feature = "stdarch_x86_avx512", issue = "111137")] | ||
| pub unsafe fn _knot_mask32(a: __mmask32) -> __mmask32 { | ||
| a ^ 0b11111111_11111111_11111111_11111111 |
There was a problem hiding this comment.
This would be much more readable as !a.
There was a problem hiding this comment.
Fixed. It might be worth pointing out that _knot_mask16 in avx512f.rs and _knot_mask8 in avx512dq.rs are written in the same way and should be changed in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.