detect more failure cases #98
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skgland
changed the title
to prevent them from diverging in the future - adjust Command::process_lines to change the 'pl lifetime when changing the processing function
the message is slightly different if there exists a potentially typoed crate
Skgland
force-pushed
the
detect-broken-manifest-while-fetching-deps
branch
from
5c2bc45 to
0173b2d
Compare
it's helpful to add tests that confirmes that a case isn't handled before handling it and then updating the test
|
I totally forgot about this PR, generally don't hesitate to ping me if that happens again. Will try to find some time to do a first review this week. |
syphar
approved these changes
May 23, 2025
There was a problem hiding this comment.
so, I did a high level check of the code & the tests.
From a pure code perspective it looks good to me.
Thing is: I have not enough cargo & crater knowledge to judge if what you're doing is generally correct.
So I'll reach out to some other people to also validate this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is best reviewed commit-by-commit.
The first commit adds a sanity check for the buildtest crates and fixes an existing deviation.
The second commits adds a bunch of buildtest tests and crates that weren't handled before this PR.
The added tests/crates have been found by looking through the crater runs classifier as
Errorin the crater experiment beta-1.86-1.The remaining commits work through the added tests to properly classify them.
With these crates classified crater should sort them into the
Brokencategory rather than theErrorcategory. (For the existingPrepareErrorvariants immediately when the dependency is updated, for the new variants they would need to be added to be recognized in detect_broken)