rustfmt: Add --file-lines flag behind an env var #844
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamalmarhubi
force-pushed
the
line-ranges
branch
from
03937af to
82da644
Compare
kamalmarhubi
changed the title
|
Failure is in the regex crate on nightly. |
kamalmarhubi
force-pushed
the
line-ranges
branch
from
82da644 to
556ee52
Compare
|
Rebased to pick up nightly fixes in #843. |
kamalmarhubi
force-pushed
the
line-ranges
branch
3 times, most recently
from
129d694 to
aa42521
Compare
kamalmarhubi
changed the title
kamalmarhubi
force-pushed
the
line-ranges
branch
from
aa42521 to
8412277
Compare
|
Rebased to fix conflicts, and now using an env var instead of a cargo feature. Aim is to have less upheaval necessary when enabling the flag by default. |
kamalmarhubi
force-pushed
the
line-ranges
branch
from
8412277 to
2716a92
Compare
This adds a `--file-lines` flag that is present if the RUSTFMT_EXPERIMENTAL_FILE_LINES environment variable is set to "1". The argument is parsed and propagated into the config, but so far it is only an alternative and verbose way to specify files and set `skip_children`. Refs https://github.com/nrc/rustfmt/issues/434
kamalmarhubi
force-pushed
the
line-ranges
branch
from
2716a92 to
ffdf9bd
Compare
|
Please let me know when you're looking at this. I'm occasionally making edits to this, but will stop the instant it's under review. |
|
Actually I'll just close this for now and reopen when I have more ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits add a
--file-linesflag that is present if the RUSTFMT_EXPERIMENTAL_FILE_LINES environment variable is set to "1". The argument is parsed and propagated into the config, but so far it is only an alternative and verbose way to specify files and setskip_children.Refs #434