Some clippy changes #2975
Merged
Some clippy changes #2975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These all seem fine, thank you! Feel free to continue, in general there are some Clippy lints which are not of great value to apply post hoc, but if you don't mind doing the work then I'm happy to take the patches :-) |
|
OK @nrc ! Let me know if there's more supply of Good First Issues - I've been hunting for some, but lots look tough |
Merged
It's not a great time for easy issues, unfortunately - we're mainly looking at fixing all the minor bugs for the 1.0 release. Your best bet is probably picking an interesting sounding issue and I can try to give enough help that you can address it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to familiarize myself with the library (and with intermediate rust) - I find going through clippy's suggestions a reasonable way of doing that.
Let me know if these are helpful and I can continue. Some of them seem helpful; some very marginal