`use self;` gets entirely deleted

[emilyyyylime]

before:

// hi
use me; // me
use self; // self
use this; // this
// bye

after:

// hi
 // self
use me; // me
use this; // this
// bye

use self; is indeed invalid but I think it's more useful for users to see the rustc error (self imports are only allowed within a { } list) than for the line to be entirely deleted.

[emilyyyylime]

I guess this also causes non-canonical formats :P (although eventually canonical):

use self::self::self::self;

->

use self::self::self;

->

use self::self;

->

use self;

->

[ytmimi]

Thanks for the report. I feel like removing use self; is probably fine given that it's not valid, but the fact that this isn't idempotent is an issue. It's possible that the solution here is just to keep the use self; and let users hit the rustc error like you suggested.

[MarcusGrass]

I made a fix-pr, interestingly, removing use self; isn't what causes the idempotence issue, it's normalizing foo::self. Removing a single use self; would be idempotent but in the specific case of normalizing away the last self, self-stacking causes this issue. The PR removes both cases, but it could be modified so that use self; will be formatted away, while use self::self; wouldn't be, that'd also be idempotent.
But, maybe it's best that the person writing the code gets to know from the compiler that what they're doing isn't valid.