This repository was archived by the owner on Nov 24, 2023. It is now read-only.
Bump version to 0.4.6 and add change log #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hm, 2 tests fail. Probably because of changes in the diagnostic output. I'll into those separately and rebase this later. |
Collaborator
|
Let me know if you need help with them. Also, can this line be removed? It doesn't look like it really needs nightly, and that's the only thing requiring it. Probably doesn't matter much if you are guaranteeing the tests only pass on nightly, though, I was just surprised (and the error was not clear). Might also be good to have a note somewhere (docs or an assert in code) about the required rustc version, so people like me don't get confused by errors using the wrong version. |
Collaborator
|
I posted #172 to update the tests. |
alexcrichton
force-pushed
the
release/0.4.6
branch
from
cc0d327 to
e6bb424
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.