Disable -Zfunction-sections by default on Windows #1554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lqd
reviewed
Jan 14, 2025
|
is it only being disabled for msvc btw? (from a quick look there wasn't code mentioning msvc) |
bjorn3
force-pushed
the
fix_msvc_linker_hang
branch
from
da12e56 to
5b7d258
Compare
Yes, it was. I have changed it to disabling it on all Windows targets though as rustc disables it on MinGW already anyway. |
bjorn3
changed the title
|
(Lol the msvc check was right in there I am a doofus) |
To workaround a hang in link.exe.
bjorn3
force-pushed
the
fix_msvc_linker_hang
branch
from
5b7d258 to
e7609d6
Compare
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 20, 2025
…bjorn3 Subtree sync for rustc_codegen_cranelift Nothing too exciting this time, but this includes a fix for a linker hang on Windows: rust-lang/rustc_codegen_cranelift#1554 r? `@ghost` `@rustbot` label +A-codegen +A-cranelift +T-compiler
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 20, 2025
…bjorn3 Subtree sync for rustc_codegen_cranelift Nothing too exciting this time, but this includes a fix for a linker hang on Windows: rust-lang/rustc_codegen_cranelift#1554 r? ``@ghost`` ``@rustbot`` label +A-codegen +A-cranelift +T-compiler
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 20, 2025
Rollup merge of rust-lang#135776 - bjorn3:sync_cg_clif-2025-01-20, r=bjorn3 Subtree sync for rustc_codegen_cranelift Nothing too exciting this time, but this includes a fix for a linker hang on Windows: rust-lang/rustc_codegen_cranelift#1554 r? ``@ghost`` ``@rustbot`` label +A-codegen +A-cranelift +T-compiler
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Jan 22, 2025
Subtree sync for rustc_codegen_cranelift Nothing too exciting this time, but this includes a fix for a linker hang on Windows: rust-lang/rustc_codegen_cranelift#1554 r? ``@ghost`` ``@rustbot`` label +A-codegen +A-cranelift +T-compiler
bjorn3
pushed a commit
that referenced
this pull request
Jan 23, 2025
Subtree sync for rustc_codegen_cranelift Nothing too exciting this time, but this includes a fix for a linker hang on Windows: #1554 r? ``@ghost`` ``@rustbot`` label +A-codegen +A-cranelift +T-compiler
github-merge-queue bot
pushed a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Feb 10, 2025
Subtree sync for rustc_codegen_cranelift Nothing too exciting this time, but this includes a fix for a linker hang on Windows: rust-lang/rustc_codegen_cranelift#1554 r? ``@ghost`` ``@rustbot`` label +A-codegen +A-cranelift +T-compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To workaround a hang in link.exe.
Fixes #1553