fix(collector): allow unused imports in serde-1.0.136#1736
fix(collector): allow unused imports in serde-1.0.136#1736Mark-Simulacrum merged 1 commit intorust-lang:masterfrom bvanjoi:allow-unused-imports-in-serde
Conversation
|
It's possible that there are also some other benchmarks that fail, as we have only tried the "training crates" on CI, but since the build didn't succeed, the full benchmark run didn't finish. If you have a build of the compiler with the corresponding change from the PR, could you please try to run the whole compilation benchmark suite locally, to see if it works? $ cargo build
$ cargo run --bin collector bench_local <path-to-rustc> --self-profileWe should make sure that it works, because after we update |
I sequentially ran
But there has another errors:
I'm uncertain if this error aligns with the expected outcome, but it appears unrelated to rust-lang/rust#116033. |
|
Yes that appears to be flaky, possibly some OS X thing. Thanks! I will create a PR on rust-lang/rust to sync rustc-perf. |
cc @Kobzol