Individual builds for all rolled up PRs #1372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing rust-timer build $SHA support should work okay for this, I think. We might want to have the automation added here leave a comment about the queued builds with the rollup PR to pushed commit mapping though, since it'll be annoying to get that otherwise - I think that's not yet implemented? (I may have missed it) |
This was referenced Aug 1, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time bors merges a rollup PR, we will now create rustc artifacts for all of the individual PRs in the roll up.
This is accomplished by creating a merge commit between the master commit at the time the rollup was merged and the head of each rollup PR. Each of these merge commits is then pushed to the try-perf where a try build CI run will be kicked off.
In and of itself, this does not help with roll up perf problems as this only builds the artifacts - it does not perform any performance run. After we have this working, we'll need a way to kick off perf runs for a particular rolled up PR.