Update rustc_on_unimplemented docs
#2357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jieyouxu
added
S-blocked
|
Please ping me after the next beta bump, I'll merge this then. |
|
Let me know if this is now mergeable. |
jieyouxu
added
S-waiting-on-author
|
Not yet, I want to make a couple of changes. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 22, 2025
rustc_on_unimplemented cleanups Addresses some of the fixmes from rust-lang#139091 and rust-lang#140307. - switch from `_Self` to `Self` in library - properly validate that arguments in the `on` filter and the format strings are actually valid See rust-lang/rustc-dev-guide#2357 for the relevant documentation.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 23, 2025
Rollup merge of rust-lang#141130 - mejrs:use_self, r=compiler-errors rustc_on_unimplemented cleanups Addresses some of the fixmes from rust-lang#139091 and rust-lang#140307. - switch from `_Self` to `Self` in library - properly validate that arguments in the `on` filter and the format strings are actually valid See rust-lang/rustc-dev-guide#2357 for the relevant documentation.
This comment has been minimized.
This comment has been minimized.
|
rust-lang/rust#141130 got merged, we're good now :) @rustbot ready |
|
Huh, right, we should probably enable waiting-on-{review,author} flips |
jieyouxu
reviewed
May 24, 2025
src/diagnostics.md
Outdated
| @@ -930,45 +922,61 @@ Would generate the following output: | |||
|
|
|||
| ```text | |||
| error[E0277]: message | |||
| --> <anon>:14:5 | |||
| --> <file>>:10:19 | |||
There was a problem hiding this comment.
Nit:
Suggested change
| --> <file>>:10:19 | |
| --> <file>:10:19 |
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
May 26, 2025
rustc_on_unimplemented cleanups Addresses some of the fixmes from rust-lang#139091 and rust-lang#140307. - switch from `_Self` to `Self` in library - properly validate that arguments in the `on` filter and the format strings are actually valid See rust-lang/rustc-dev-guide#2357 for the relevant documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that these docs reflect the current implementation but some fixes and updates have not percolated into the bootstrap compiler yet:
"{This}"is not supported_Selfbut notSelf.So I guess we should avoid merging this until the middle of May?
Rendered