Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rfl ci job policy #2108

Merged
merged 1 commit into from
Oct 31, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions src/tests/rust-for-linux.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,25 @@ integration.

## What to do in case of failure

Currently, we use the following unofficial policy for handling failures caused
by a change breaking the RfL integration:

- If the breakage was unintentional, then fix the PR.
- If the breakage was intentional, then let [RFL][rfl-ping] know and discuss
If a PR breaks the Rust for Linux CI job, then:

- If the breakage was unintentional and seems spurious, then let [RfL][rfl-ping]
know and retry.
- If the PR is urgent and retrying doesn't fix it, then disable the CI job
temporarily (comment out the `image: x86_64-rust-for-linux` job in
`src/ci/github-actions/jobs.yml`).
- If the breakage was unintentional, then change the PR to resolve the breakage.
- If the breakage was intentional, then let [RfL][rfl-ping] know and discuss
what will the kernel need to change.
- If the PR is urgent, then disable the test temporarily.
- If the PR can wait a few days, then wait for RFL maintainers to provide a
- If the PR is urgent, then disable the CI job temporarily (comment out
the `image: x86_64-rust-for-linux` job in `src/ci/github-actions/jobs.yml`).
- If the PR can wait a few days, then wait for RfL maintainers to provide a
new Linux kernel commit hash with the needed changes done, and apply it to
the PR, which would confirm the changes work.
the PR, which would confirm the changes work (update the `LINUX_VERSION`
environment variable in `src/ci/docker/scripts/rfl-build.sh`).

If something goes wrong with the workflow, you can ping the [Rust for
Linux][rfl-ping] ping group to ask for help.
If you need to contact the RfL developers, you can ping the [Rust for Linux][rfl-ping]
ping group to ask for help:

```text
@rustbot ping rfl
Expand Down