Skip to content

Update rust-analyzer config checkOnSave -> check #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lukas-code
Copy link
Member

This setting was renamed in rust-lang/rust-analyzer#13799.

Turns out that was the reason my analyzer hasn't been working recently.

@flodiebold
Copy link
Member

The old config keys should still work though, right @Veykril ?

@Veykril
Copy link
Member

Veykril commented Jan 18, 2023

Ye we should still be accepting the old key here 🤔

@lukas-code
Copy link
Member Author

This might be a rust-analyzer bug then. I just double checked with r-a default settings and the old config doesn't work, but with this patch it works.

r-a version: 0.4.1371-standalone

@Veykril
Copy link
Member

Veykril commented Jan 18, 2023

I'll look into it.

@Veykril
Copy link
Member

Veykril commented Jan 18, 2023

Found the problem rust-lang/rust-analyzer#13980, we should still update the dev-guide to be up to date, but ideally let this PR sit for a bit, since I assume some people that work on rustc might be using the rust-analyzer shipped as a stable rustup component which doesn't have the updated configs yet.

@JohnTitor JohnTitor added the S-blocked Status: this PR is blocked waiting for something label Feb 2, 2023
@clubby789
Copy link
Contributor

The suggested config has been moved into bootstrap here.

@lukas-code
Copy link
Member Author

I'll close this per #1562 (comment). The config in the rust repo should still be updated eventually.

@lukas-code lukas-code closed this Feb 9, 2023
@lukas-code lukas-code deleted the patch-1 branch February 9, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: this PR is blocked waiting for something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants