Rollup of 4 pull requests #99687
Merged
Rollup of 4 pull requests #99687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the source_file_to_parser and the maybe_source_file_to_parse function's doc comments which currently refer to a config parameter. The doc comments have been updated to refer to the 'session' parameter similar to the doc comment for try_file_to_source_file, which also takes a &Session parameter.
…e, r=oli-obk remove some provenance-related machine hooks that Miri no longer needs Then we can make `scalar_to_ptr` a method on `Scalar`. :) Fixes rust-lang/miri#2188 r? `@oli-obk`
Docs - remove unnecessary `mut` that gives a warning Fixes rust-lang#99654. A trivial linting fix for a Stdio example. `@rustbot` label +T-lib
… r=Dylan-DPC Remove Clean trait implementation for more items Follow up of rust-lang#99638. cc `@camelid` r? `@notriddle`
…nts, r=cjgillot Update doc comments that refer to config parameter This commit updates the `source_file_to_parser` and the `maybe_source_file_to_parse` function's doc comments which currently refer to a `config` parameter. The doc comments have been updated to refer to the `session` parameter similar to the doc comment for `try_file_to_source_file`, which also takes a `&Session` parameter.
rustbot
added
T-compiler
|
@bors r+ p=5 |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jul 24, 2022
Tested on commit rust-lang/rust@7fe022f. Direct link to PR: <rust-lang/rust#99687> 💔 miri on windows: test-fail → build-fail (cc @oli-obk @RalfJung). 💔 miri on linux: test-fail → build-fail (cc @oli-obk @RalfJung).
|
Finished benchmarking commit (7fe022f): comparison url. Instruction count
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
mutthat gives a warning #99657 (Docs - remove unnecessarymutthat gives a warning)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup