Update to LLVM 15 #99464

nikic · 2022-07-19T12:03:53Z

For preliminary testing. Some LLVM 15 compatibility fixes were applied separately in #99512.

Release timeline:

LLVM 15 branched on Jul 26.
The final LLVM 15.0.0 release is scheduled for Sep 6.
Current nightly (1.65.0) is scheduled for Nov 3.

Changes in this PR (apart from the LLVM update):

Pass --set llvm.allow-old-toolchain for many Docker images. LLVM 16 will require GCC >= 7.1, while LLVM 15 still allows older compilers with an option. Specify the option for builders still using GCC 5.4. Increase the minimum linux-gnu versions #95026 updated some of the used toolchains, but not all.
Use the +atomics-32 target feature for thumbv6m.
Explicitly link libatomic when cross-compiling LLVM to 32-bit target.
Explicitly disable zstd support, to avoid libzstd.so dependency.

New LLVM patches (commits):

[rust-only] Fix ICE with GCC 5.4 (nikic/llvm-project@15be58d)
[rust-only] Fix build with GCC 5.4 (nikic/llvm-project@774edc1)
~~[rust-only] Fix build with GCC 5.2 (nikic/llvm-project@1a6069a)~~
~~[rust-only] Fix ICE with GCC 5.2 (nikic/llvm-project@493081f)~~
~~[rust-only] Fix build with GCC 5.2 (nikic/llvm-project@0fc5979)~~
[backported] Addition of +atomics target feature (llvm/llvm-project@57bdd98).
[backported] Revert compiler-rt change that broke powerpc (llvm/llvm-project@9c68b43)
[awaiting backport] Fix RelLookupTableConverter on gnux32 (nikic/llvm-project@639388a / Backport fix for RelLookupTableConverter on gnux32 llvm/llvm-project#57021)

Tested images: dist-x86_64-linux, armhf-gnu, arm-android, dist-s390x-linux, dist-x86_64-illumos, dist-x86_64-freebsd, wasm32, dist-x86_64-musl, dist-various-1, dist-riscv64-linux, dist-mips-linux, dist-mipsel-linux, dist-powerpc-linux, dist-aarch64-linux, dist-x86_64-apple, x86_64-msvc-1, x86_64-msvc-2, dist-various-2, dist-arm-linux
Tested up to the usual ipv6 error: test-various, i686-gnu, x86_64-gnu-nopt

r? @ghost

nikic · 2022-07-19T12:04:12Z

@bors try @rust-timer queue

rust-timer · 2022-07-19T12:04:13Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-07-19T12:04:20Z

⌛ Trying commit 0ceee8b7152a92eef0354b1191d3665e2b807c8a with merge 3a4b1ad25e31a3f4fb5cff5a74a92b947850957e...

nikic · 2022-07-19T14:53:55Z

@rust-timer build 3a4b1ad25e31a3f4fb5cff5a74a92b947850957e

rust-timer · 2022-07-19T14:53:57Z

Queued 3a4b1ad25e31a3f4fb5cff5a74a92b947850957e with parent 4603ac3, future comparison URL.

rust-timer · 2022-07-19T16:24:17Z

Finished benchmarking commit (3a4b1ad25e31a3f4fb5cff5a74a92b947850957e): comparison url.

Instruction count

Primary benchmarks: mixed results
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	0.7%	8.1%	68
Regressions 😿 (secondary)	1.0%	5.5%	51
Improvements 🎉 (primary)	-1.5%	-4.6%	91
Improvements 🎉 (secondary)	-2.8%	-21.0%	83
All 😿🎉 (primary)	-0.6%	8.1%	159

Max RSS (memory usage)

Results

Primary benchmarks: mixed results
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	2.4%	5.7%	7
Regressions 😿 (secondary)	3.6%	6.2%	5
Improvements 🎉 (primary)	-4.4%	-7.1%	4
Improvements 🎉 (secondary)	-14.0%	-34.5%	11
All 😿🎉 (primary)	-0.1%	-7.1%	11

Cycles

Results

Primary benchmarks: mixed results
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	6.5%	9.2%	3
Regressions 😿 (secondary)	7.1%	9.5%	9
Improvements 🎉 (primary)	-3.5%	-5.9%	24
Improvements 🎉 (secondary)	-8.8%	-21.1%	16
All 😿🎉 (primary)	-2.4%	9.2%	27

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

nikic · 2022-07-20T20:13:14Z

I believe this is due to https://reviews.llvm.org/D120026. Previously, LLVM incorrectly emitted plain loads and stores for atomic loads and stores for the thumbv6 target. We should be setting max_atomic_width = Some(0) for this target.

nikic · 2022-07-21T15:56:10Z

dist-various-2 build failure for aarch64-fuchsia:

  running: "sccache" "aarch64-fuchsia-clang" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=aarch64-fuchsia" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=aarch64-fuchsia" "-I" "/checkout/src/llvm-project/compiler-rt/lib/builtins" "-fno-builtin" "-fvisibility=hidden" "-ffreestanding" "-fomit-frame-pointer" "-DVISIBILITY_HIDDEN" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/aarch64-fuchsia/release/build/compiler_builtins-997f5fa9cc5c4633/out/cpu_model.o" "-c" "/checkout/src/llvm-project/compiler-rt/lib/builtins/cpu_model.c"
  cargo:warning=/checkout/src/llvm-project/compiler-rt/lib/builtins/cpu_model.c:812:10: fatal error: 'zircon/features.h' file not found
  cargo:warning=#include <zircon/features.h>
  cargo:warning=         ^~~~~~~~~~~~~~~~~~~
  cargo:warning=1 error generated.
  exit status: 1

  --- stderr


  error occurred: Command "sccache" "aarch64-fuchsia-clang" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=aarch64-fuchsia" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=aarch64-fuchsia" "-I" "/checkout/src/llvm-project/compiler-rt/lib/builtins" "-fno-builtin" "-fvisibility=hidden" "-ffreestanding" "-fomit-frame-pointer" "-DVISIBILITY_HIDDEN" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/aarch64-fuchsia/release/build/compiler_builtins-997f5fa9cc5c4633/out/cpu_model.o" "-c" "/checkout/src/llvm-project/compiler-rt/lib/builtins/cpu_model.c" with args "aarch64-fuchsia-clang" did not execute successfully (status code exit status: 1).

nikic · 2022-07-22T08:38:58Z

Reference to zircon/features.h was added in llvm/llvm-project@4e731ab. It looks like the zircon/features.h header is newer than Rust's mirror of zircon, which is from Sep 2017: https://github.com/rust-lang/mirror-google-fuchsia-zircon/tree/rust-ci-mirror-2019-05-09/system/public/zircon That's ... a bit dated :)

@tmandry @petrhosek Assuming you are responsible for this target (I'm guessing based on #99500 -- would be great to indicate who the target maintainers are on https://doc.rust-lang.org/nightly/rustc/platform-support.html), would it be possible to update the Fuchsia toolchain we use in CI to a newer version?

tmandry · 2022-07-22T14:36:02Z

would it be possible to update the Fuchsia toolchain we use in CI to a newer version?

This is planned to be done in the next couple months, but we haven't started yet. We'll prioritize unblocking you somehow.

I'll see about adding target docs. In the meantime you can use @rustbot ping fuchsia.

rustbot · 2022-07-22T14:36:04Z

Hey friends of Fuchsia! This issue could use some guidance on how this should be
resolved/implemented on Fuchsia. Could one of you weigh in?

cc @ComputerDruid @djkoloski @P1n3appl3 @tmandry

bors · 2022-08-12T02:58:54Z

⌛ Testing commit 115dfe2 with merge e2b52ff...

bors · 2022-08-12T06:45:29Z

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing e2b52ff to master...

rust-timer · 2022-08-12T08:01:10Z

Finished benchmarking commit (e2b52ff): comparison url.

Instruction count

Primary benchmarks: mixed results
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions ❌ (primary)	0.8%	7.5%	40
Regressions ❌ (secondary)	1.2%	4.4%	29
Improvements ✅ (primary)	-1.5%	-6.0%	100
Improvements ✅ (secondary)	-2.6%	-21.6%	94
All ❌✅ (primary)	-0.9%	7.5%	140

Max RSS (memory usage)

Results

Primary benchmarks: mixed results
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions ❌ (primary)	1.7%	2.1%	8
Regressions ❌ (secondary)	2.6%	3.8%	2
Improvements ✅ (primary)	-3.5%	-6.9%	7
Improvements ✅ (secondary)	-11.5%	-31.1%	13
All ❌✅ (primary)	-0.7%	-6.9%	15

Cycles

Results

Primary benchmarks: mixed results
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions ❌ (primary)	4.6%	8.1%	5
Regressions ❌ (secondary)	5.2%	7.3%	19
Improvements ✅ (primary)	-3.4%	-5.7%	35
Improvements ✅ (secondary)	-9.0%	-23.5%	18
All ❌✅ (primary)	-2.4%	8.1%	40

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

nnethercote · 2022-08-12T08:20:15Z

The wins here clearly outweight the losses. A 4% reduction in bootstrap time is particularly nice.

@rustbot label: +perf-regression-triaged

Pkgsrc changes: * We now manage to build for mipsel-unknown-netbsd, but despite the target spec saying cpu = "mips3", the compiler manages to emit 64-bit instructions which cause "illegal instruction" error. Will need more work. The mipsel-unknown-netbsd entry is commentd out since there is no 1.64.0 bootstrap. * Managed to retain the build of aarch64_be, llvm needed a patch to avoid use of neon instructions in the BE case (llvm doesn't support use of neon in BE mode). Ref. patch to src/llvm-project/llvm/lib/Support/BLAKE3/blake3_impl.h. * The minimum gcc version is now 7.x, and that includes the cross-compiler for the targets. For i386 this also needs to /usr/include/gcc-7 include files in the target root, because immintrin.h from gcc 5 is not compatible with gcc 7.x. This applies for the targets where we build against a root from netbsd-8 (sparc64, powerpc, i386), and files/gcc-wrap gets a hack for this. * Pick up tweak for -latomic inclusion from rust-lang/rust#104220 and rust-lang/rust#104572 * Retain ability to do 32-bit NetBSD, by changing from 64 to 32 bit types in library/std/src/sys/unix/thread_parker/netbsd.rs. * I've struggled a bit to get the "openssl-src" build with -latomic where it's needed. I introduce "NetBSD-generic32" system type and use it for the NetBSD mipsel target. There is another attempt to do the same in the patch to vendor/openssl-sys/build/main.rs. * Bump bootstraps to 1.64.0, checksum updates. Upstream changes: Version 1.65.0 (2022-11-03) ========================== Language -------- - [Error on `as` casts of enums with `#[non_exhaustive]` variants] (rust-lang/rust#92744) - [Stabilize `let else`](rust-lang/rust#93628) - [Stabilize generic associated types (GATs)] (rust-lang/rust#96709) - [Add lints `let_underscore_drop`, `let_underscore_lock`, and `let_underscore_must_use` from Clippy] (rust-lang/rust#97739) - [Stabilize `break`ing from arbitrary labeled blocks ("label-break-value")] (rust-lang/rust#99332) - [Uninitialized integers, floats, and raw pointers are now considered immediate UB](rust-lang/rust#98919). Usage of `MaybeUninit` is the correct way to work with uninitialized memory. - [Stabilize raw-dylib for Windows x86_64, aarch64, and thumbv7a] (rust-lang/rust#99916) - [Do not allow `Drop` impl on foreign ADTs] (rust-lang/rust#99576) Compiler -------- - [Stabilize -Csplit-debuginfo on Linux] (rust-lang/rust#98051) - [Use niche-filling optimization even when multiple variants have data] (rust-lang/rust#94075) - [Associated type projections are now verified to be well-formed prior to resolving the underlying type] (rust-lang/rust#99217) - [Stringify non-shorthand visibility correctly] (rust-lang/rust#100350) - [Normalize struct field types when unsizing] (rust-lang/rust#101831) - [Update to LLVM 15](rust-lang/rust#99464) - [Fix aarch64 call abi to correctly zeroext when needed] (rust-lang/rust#97800) - [debuginfo: Generalize C++-like encoding for enums] (rust-lang/rust#98393) - [Add `special_module_name` lint] (rust-lang/rust#94467) - [Add support for generating unique profraw files by default when using `-C instrument-coverage`] (rust-lang/rust#100384) - [Allow dynamic linking for iOS/tvOS targets] (rust-lang/rust#100636) New targets: - [Add armv4t-none-eabi as a tier 3 target] (rust-lang/rust#100244) - [Add powerpc64-unknown-openbsd and riscv64-unknown-openbsd as tier 3 targets] (rust-lang/rust#101025) - Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Don't generate `PartialEq::ne` in derive(PartialEq)] (rust-lang/rust#98655) - [Windows RNG: Use `BCRYPT_RNG_ALG_HANDLE` by default] (rust-lang/rust#101325) - [Forbid mixing `System` with direct system allocator calls] (rust-lang/rust#101394) - [Document no support for writing to non-blocking stdio/stderr] (rust-lang/rust#101416) - [`std::layout::Layout` size must not overflow `isize::MAX` when rounded up to `align`](rust-lang/rust#95295) This also changes the safety conditions on `Layout::from_size_align_unchecked`. Stabilized APIs --------------- - [`std::backtrace::Backtrace`] (https://doc.rust-lang.org/stable/std/backtrace/struct.Backtrace.html) - [`Bound::as_ref`] (https://doc.rust-lang.org/stable/std/ops/enum.Bound.html#method.as_ref) - [`std::io::read_to_string`] (https://doc.rust-lang.org/stable/std/io/fn.read_to_string.html) - [`<*const T>::cast_mut`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.cast_mut) - [`<*mut T>::cast_const`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.cast_const) These APIs are now stable in const contexts: - [`<*const T>::offset_from`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.offset_from) - [`<*mut T>::offset_from`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.offset_from) Cargo ----- - [Apply GitHub fast path even for partial hashes] (rust-lang/cargo#10807) - [Do not add home bin path to PATH if it's already there] (rust-lang/cargo#11023) - [Take priority into account within the pending queue] (rust-lang/cargo#11032). This slightly optimizes job scheduling by Cargo, with typically small improvements on larger crate graph builds. Compatibility Notes ------------------- - [`std::layout::Layout` size must not overflow `isize::MAX` when rounded up to `align`] (rust-lang/rust#95295). This also changes the safety conditions on `Layout::from_size_align_unchecked`. - [`PollFn` now only implements `Unpin` if the closure is `Unpin`] (rust-lang/rust#102737). This is a possible breaking change if users were relying on the blanket unpin implementation. See discussion on the PR for details of why this change was made. - [Drop ExactSizeIterator impl from std::char::EscapeAscii] (rust-lang/rust#99880) This is a backwards-incompatible change to the standard library's surface area, but is unlikely to affect real world usage. - [Do not consider a single repeated lifetime eligible for elision in the return type] (rust-lang/rust#103450) This behavior was unintentionally changed in 1.64.0, and this release reverts that change by making this an error again. - [Reenable disabled early syntax gates as future-incompatibility lints] (rust-lang/rust#99935) - [Update the minimum external LLVM to 13] (rust-lang/rust#100460) - [Don't duplicate file descriptors into stdio fds] (rust-lang/rust#101426) - [Sunset RLS](rust-lang/rust#100863) - [Deny usage of `#![cfg_attr(..., crate_type = ...)]` to set the crate type] (rust-lang/rust#99784) This strengthens the forward compatibility lint deprecated_cfg_attr_crate_type_name to deny. - [`llvm-has-rust-patches` allows setting the build system to treat the LLVM as having Rust-specific patches] (rust-lang/rust#101072) This option may need to be set for distributions that are building Rust with a patched LLVM via `llvm-config`, not the built-in LLVM. Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Add `x.sh` and `x.ps1` shell scripts] (rust-lang/rust#99992) - [compiletest: use target cfg instead of hard-coded tables] (rust-lang/rust#100260) - [Use object instead of LLVM for reading bitcode from rlibs] (rust-lang/rust#98100) - [Enable MIR inlining for optimized compilations] (rust-lang/rust#91743) This provides a 3-10% improvement in compiletimes for real world crates. See [perf results] (https://perf.rust-lang.org/compare.html?start=aedf78e56b2279cc869962feac5153b6ba7001ed&end=0075bb4fad68e64b6d1be06bf2db366c30bc75e1&stat=instructions:u).

Pkgsrc changes: * pkglint cleanups, bump bootstrap kits to 1.65.0. * New target: mipsel-unknown-netbsd, for cpu=mips32 with soft-float. * Managed to retain the build of aarch64_be, llvm needed a patch to avoid use of neon instructions in the BE case (llvm doesn't support use of neon in BE mode). Ref. patch to src/llvm-project/llvm/lib/Support/BLAKE3/blake3_impl.h. Also submitted upstream of LLVM to the BLAKE3 maintainers. * The minimum gcc version is now 7.x, and that includes the cross-compiler for the targets. For i386 this also needs to /usr/include/gcc-7 include files in the target root, because immintrin.h from gcc 5 is not compatible with gcc 7.x. This applies for the targets where we build against a root from netbsd-8 (sparc64, powerpc, i386), and files/gcc-wrap gets a hack for this. * Pick up tweak for -latomic inclusion from rust-lang/rust#104220 and rust-lang/rust#104572 * Retain ability to do 32-bit NetBSD, by changing from 64 to 32 bit types in library/std/src/sys/unix/thread_parker/netbsd.rs. * I've tried to get the "openssl-src" build with -latomic where it's needed. I've introduced the "NetBSD-generic32" system type and use it for the NetBSD mipsel target. There is another attempt to do the same in the patch to vendor/openssl-sys/build/main.rs. Upstream changes: Version 1.66.1 (2023-01-10) =========================== - Added validation of SSH host keys for git URLs in Cargo ([CVE-2022-46176](https://www.cve.org/CVERecord?id=CVE-2022-46176)) Version 1.66.0 (2022-12-15) =========================== Language -------- - [Permit specifying explicit discriminants on all `repr(Int)` enums](rust-lang/rust#95710) ```rust #[repr(u8)] enum Foo { A(u8) = 0, B(i8) = 1, C(bool) = 42, } ``` - [Allow transmutes between the same type differing only in lifetimes](rust-lang/rust#101520) - [Change constant evaluation errors from a deny-by-default lint to a hard error](rust-lang/rust#102091) - [Trigger `must_use` on `impl Trait` for supertraits](rust-lang/rust#102287) This makes `impl ExactSizeIterator` respect the existing `#[must_use]` annotation on `Iterator`. - [Allow `..X` and `..=X` in patterns](rust-lang/rust#102275) - [Uplift `clippy::for_loops_over_fallibles` lint into rustc](rust-lang/rust#99696) - [Stabilize `sym` operands in inline assembly](rust-lang/rust#103168) - [Update to Unicode 15](rust-lang/rust#101912) - [Opaque types no longer imply lifetime bounds](rust-lang/rust#95474) This is a soundness fix which may break code that was erroneously relying on this behavior. Compiler -------- - [Add armv5te-none-eabi and thumbv5te-none-eabi tier 3 targets](rust-lang/rust#101329) - Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. - [Add support for linking against macOS universal libraries](rust-lang/rust#98736) Libraries --------- - [Fix `#[derive(Default)]` on a generic `#[default]` enum adding unnecessary `Default` bounds](rust-lang/rust#101040) - [Update to Unicode 15](rust-lang/rust#101821) Stabilized APIs --------------- - [`proc_macro::Span::source_text`](https://doc.rust-lang.org/stable/proc_macro/struct.Span.html#method.source_text) - [`uX::{checked_add_signed, overflowing_add_signed, saturating_add_signed, wrapping_add_signed}`](https://doc.rust-lang.org/stable/std/primitive.u8.html#method.checked_add_signed) - [`iX::{checked_add_unsigned, overflowing_add_unsigned, saturating_add_unsigned, wrapping_add_unsigned}`](https://doc.rust-lang.org/stable/std/primitive.i8.html#method.checked_add_unsigned) - [`iX::{checked_sub_unsigned, overflowing_sub_unsigned, saturating_sub_unsigned, wrapping_sub_unsigned}`](https://doc.rust-lang.org/stable/std/primitive.i8.html#method.checked_sub_unsigned) - [`BTreeSet::{first, last, pop_first, pop_last}`](https://doc.rust-lang.org/stable/std/collections/struct.BTreeSet.html#method.first) - [`BTreeMap::{first_key_value, last_key_value, first_entry, last_entry, pop_first, pop_last}`](https://doc.rust-lang.org/stable/std/collections/struct.BTreeMap.html#method.first_key_value) - [Add `AsFd` implementations for stdio lock types on WASI.](rust-lang/rust#101768) - [`impl TryFrom<Vec<T>> for Box<[T; N]>`](https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#impl-TryFrom%3CVec%3CT%2C%20Global%3E%3E-for-Box%3C%5BT%3B%20N%5D%2C%20Global%3E) - [`core::hint::black_box`](https://doc.rust-lang.org/stable/std/hint/fn.black_box.html) - [`Duration::try_from_secs_{f32,f64}`](https://doc.rust-lang.org/stable/std/time/struct.Duration.html#method.try_from_secs_f32) - [`Option::unzip`](https://doc.rust-lang.org/stable/std/option/enum.Option.html#method.unzip) - [`std::os::fd`](https://doc.rust-lang.org/stable/std/os/fd/index.html) Rustdoc ------- - [Add Rustdoc warning for invalid HTML tags in the documentation](rust-lang/rust#101720) Cargo ----- - [Added `cargo remove` to remove dependencies from Cargo.toml](https://doc.rust-lang.org/nightly/cargo/commands/cargo-remove.html) - [`cargo publish` now waits for the new version to be downloadable before exiting](rust-lang/cargo#11062) See [detailed release notes](https://github.com/rust-lang/cargo/blob/master/CHANGELOG.md#cargo-166-2022-12-15) for more. Compatibility Notes ------------------- - [Only apply `ProceduralMasquerade` hack to older versions of `rental`](rust-lang/rust#94063) - [Don't export `__heap_base` and `__data_end` on wasm32-wasi.](rust-lang/rust#102385) - [Don't export `__wasm_init_memory` on WebAssembly.](rust-lang/rust#102426) - [Only export `__tls_*` on wasm32-unknown-unknown.](rust-lang/rust#102440) - [Don't link to `libresolv` in libstd on Darwin](rust-lang/rust#102766) - [Update libstd's libc to 0.2.135 (to make `libstd` no longer pull in `libiconv.dylib` on Darwin)](rust-lang/rust#103277) - [Opaque types no longer imply lifetime bounds](rust-lang/rust#95474) This is a soundness fix which may break code that was erroneously relying on this behavior. - [Make `order_dependent_trait_objects` show up in future-breakage reports](rust-lang/rust#102635) - [Change std::process::Command spawning to default to inheriting the parent's signal mask](rust-lang/rust#101077) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Enable BOLT for LLVM compilation](rust-lang/rust#94381) - [Enable LTO for rustc_driver.so](rust-lang/rust#101403) Version 1.65.0 (2022-11-03) ========================== Language -------- - [Error on `as` casts of enums with `#[non_exhaustive]` variants] (rust-lang/rust#92744) - [Stabilize `let else`](rust-lang/rust#93628) - [Stabilize generic associated types (GATs)] (rust-lang/rust#96709) - [Add lints `let_underscore_drop`, `let_underscore_lock`, and `let_underscore_must_use` from Clippy] (rust-lang/rust#97739) - [Stabilize `break`ing from arbitrary labeled blocks ("label-break-value")] (rust-lang/rust#99332) - [Uninitialized integers, floats, and raw pointers are now considered immediate UB](rust-lang/rust#98919). Usage of `MaybeUninit` is the correct way to work with uninitialized memory. - [Stabilize raw-dylib for Windows x86_64, aarch64, and thumbv7a] (rust-lang/rust#99916) - [Do not allow `Drop` impl on foreign ADTs] (rust-lang/rust#99576) Compiler -------- - [Stabilize -Csplit-debuginfo on Linux] (rust-lang/rust#98051) - [Use niche-filling optimization even when multiple variants have data] (rust-lang/rust#94075) - [Associated type projections are now verified to be well-formed prior to resolving the underlying type] (rust-lang/rust#99217) - [Stringify non-shorthand visibility correctly] (rust-lang/rust#100350) - [Normalize struct field types when unsizing] (rust-lang/rust#101831) - [Update to LLVM 15](rust-lang/rust#99464) - [Fix aarch64 call abi to correctly zeroext when needed] (rust-lang/rust#97800) - [debuginfo: Generalize C++-like encoding for enums] (rust-lang/rust#98393) - [Add `special_module_name` lint] (rust-lang/rust#94467) - [Add support for generating unique profraw files by default when using `-C instrument-coverage`] (rust-lang/rust#100384) - [Allow dynamic linking for iOS/tvOS targets] (rust-lang/rust#100636) New targets: - [Add armv4t-none-eabi as a tier 3 target] (rust-lang/rust#100244) - [Add powerpc64-unknown-openbsd and riscv64-unknown-openbsd as tier 3 targets] (rust-lang/rust#101025) - Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Don't generate `PartialEq::ne` in derive(PartialEq)] (rust-lang/rust#98655) - [Windows RNG: Use `BCRYPT_RNG_ALG_HANDLE` by default] (rust-lang/rust#101325) - [Forbid mixing `System` with direct system allocator calls] (rust-lang/rust#101394) - [Document no support for writing to non-blocking stdio/stderr] (rust-lang/rust#101416) - [`std::layout::Layout` size must not overflow `isize::MAX` when rounded up to `align`](rust-lang/rust#95295) This also changes the safety conditions on `Layout::from_size_align_unchecked`. Stabilized APIs --------------- - [`std::backtrace::Backtrace`] (https://doc.rust-lang.org/stable/std/backtrace/struct.Backtrace.html) - [`Bound::as_ref`] (https://doc.rust-lang.org/stable/std/ops/enum.Bound.html#method.as_ref) - [`std::io::read_to_string`] (https://doc.rust-lang.org/stable/std/io/fn.read_to_string.html) - [`<*const T>::cast_mut`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.cast_mut) - [`<*mut T>::cast_const`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.cast_const) These APIs are now stable in const contexts: - [`<*const T>::offset_from`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.offset_from) - [`<*mut T>::offset_from`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.offset_from) Cargo ----- - [Apply GitHub fast path even for partial hashes] (rust-lang/cargo#10807) - [Do not add home bin path to PATH if it's already there] (rust-lang/cargo#11023) - [Take priority into account within the pending queue] (rust-lang/cargo#11032). This slightly optimizes job scheduling by Cargo, with typically small improvements on larger crate graph builds. Compatibility Notes ------------------- - [`std::layout::Layout` size must not overflow `isize::MAX` when rounded up to `align`] (rust-lang/rust#95295). This also changes the safety conditions on `Layout::from_size_align_unchecked`. - [`PollFn` now only implements `Unpin` if the closure is `Unpin`] (rust-lang/rust#102737). This is a possible breaking change if users were relying on the blanket unpin implementation. See discussion on the PR for details of why this change was made. - [Drop ExactSizeIterator impl from std::char::EscapeAscii] (rust-lang/rust#99880) This is a backwards-incompatible change to the standard library's surface area, but is unlikely to affect real world usage. - [Do not consider a single repeated lifetime eligible for elision in the return type] (rust-lang/rust#103450) This behavior was unintentionally changed in 1.64.0, and this release reverts that change by making this an error again. - [Reenable disabled early syntax gates as future-incompatibility lints] (rust-lang/rust#99935) - [Update the minimum external LLVM to 13] (rust-lang/rust#100460) - [Don't duplicate file descriptors into stdio fds] (rust-lang/rust#101426) - [Sunset RLS](rust-lang/rust#100863) - [Deny usage of `#![cfg_attr(..., crate_type = ...)]` to set the crate type] (rust-lang/rust#99784) This strengthens the forward compatibility lint deprecated_cfg_attr_crate_type_name to deny. - [`llvm-has-rust-patches` allows setting the build system to treat the LLVM as having Rust-specific patches] (rust-lang/rust#101072) This option may need to be set for distributions that are building Rust with a patched LLVM via `llvm-config`, not the built-in LLVM. Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Add `x.sh` and `x.ps1` shell scripts] (rust-lang/rust#99992) - [compiletest: use target cfg instead of hard-coded tables] (rust-lang/rust#100260) - [Use object instead of LLVM for reading bitcode from rlibs] (rust-lang/rust#98100) - [Enable MIR inlining for optimized compilations] (rust-lang/rust#91743) This provides a 3-10% improvement in compiletimes for real world crates. See [perf results] (https://perf.rust-lang.org/compare.html?start=aedf78e56b2279cc869962feac5153b6ba7001ed&end=0075bb4fad68e64b6d1be06bf2db366c30bc75e1&stat=instructions:u).

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 19, 2022

This comment has been minimized.

Sign in to view

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 19, 2022

This comment has been minimized.

Sign in to view

nikic force-pushed the llvm-15 branch from 78ea1e0 to 21d0446 Compare July 19, 2022 14:44

This comment was marked as resolved.

Sign in to view

This comment has been minimized.

Sign in to view

nikic force-pushed the llvm-15 branch from 21d0446 to db00dc3 Compare July 19, 2022 15:30

rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 19, 2022

nikic mentioned this pull request Jul 20, 2022

LLVM 15 compatibility fixes #99512

Merged

This comment was marked as resolved.

Sign in to view

rustbot added the O-fuchsia Operating system: Fuchsia label Jul 22, 2022

nikic mentioned this pull request Jul 22, 2022

Increase the minimum linux-gnu versions #95026

Merged

Mark-Simulacrum removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2022

nikic force-pushed the llvm-15 branch from 4d3cb04 to 91d51a1 Compare July 27, 2022 13:09

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 12, 2022

bors merged commit e2b52ff into rust-lang:master Aug 12, 2022

rustbot added this to the 1.65.0 milestone Aug 12, 2022

cuviper added the relnotes Marks issues that should be documented in the release notes of the next release. label Aug 12, 2022

rustbot added the perf-regression-triaged The performance regression has been triaged. label Aug 12, 2022

nnethercote mentioned this pull request Aug 12, 2022

Shrink ast::Attribute. #100441

Merged

Alexendoo mentioned this pull request Aug 13, 2022

Compiler segfault in release mode, inlining/optimizing many versions of a generic function #94923

Closed

Mark-Simulacrum mentioned this pull request Aug 14, 2022

How should we expose atomic load/store on targets that don't support full atomics #99668

Open

RalfJung mentioned this pull request Aug 14, 2022

CHERI-valid pointer stuffing produces worse codegen than an implementation which does huge wrapping offsets #96152

Closed

Lymia mentioned this pull request Aug 16, 2022

undefined reference to __atomic_load_4 when compiling the agb crate #100619

Closed

kjetilkjeka mentioned this pull request Aug 16, 2022

make Condvar, Mutex, RwLock const constructors work with the unsupported impl #98457

Merged

yvt mentioned this pull request Aug 21, 2022

Doesn't compile with the latest nightly toolchain. rust-embedded/riscv-rt#102

Closed

est31 mentioned this pull request Aug 24, 2022

Box::new copies generated Future unless call is wrapped #100932

Closed

SUPERCILEX mentioned this pull request Aug 25, 2022

Add MaybeUninit memset test #98304

Merged

steffahn mentioned this pull request Aug 30, 2022

slice::get_mut() followed by slice::copy_from_slice generates unreachable panic branch #98294

Closed

Robbepop mentioned this pull request Oct 12, 2022

Massive performance regression between nightly-2022-08-12 and nightly-2022-08-13 #102952

Open

Jake-Shadle mentioned this pull request Nov 4, 2022

Debug Windows shenanigans rust-minidump/minidump-writer#63

Closed

apiraino mentioned this pull request Nov 10, 2022

riscv32imac-unknown-xous-elf: rust-lld gives offset is outside the section errors #103949

Open

arlosi mentioned this pull request Nov 17, 2022

Fix build of std for thumbv7a-pc-windows-msvc #103989

Merged

sosthene-nitrokey mentioned this pull request Nov 21, 2022

Initial fuzzing support and fixes Nitrokey/trussed-secrets-app#11

Merged

7 tasks

ojeda mentioned this pull request Dec 10, 2022

Fix building under UML Rust-for-Linux/linux#881

Merged

DaniPopes mentioned this pull request Aug 29, 2023

Performance regression of array::IntoIter vs slice::Iter #115339

Closed

boulanlo mentioned this pull request Sep 8, 2023

Multiple nested loops taking very long to compile with CPU extensions #115465

Open

khuey mentioned this pull request May 28, 2024

Enable zstd for debug compression. #125642

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to LLVM 15 #99464

Update to LLVM 15 #99464

nikic commented Jul 19, 2022 •

edited

Loading

nikic commented Jul 19, 2022

rust-timer commented Jul 19, 2022

bors commented Jul 19, 2022

This comment has been minimized.

This comment has been minimized.

This comment was marked as resolved.

nikic commented Jul 19, 2022

rust-timer commented Jul 19, 2022

This comment has been minimized.

rust-timer commented Jul 19, 2022

This comment was marked as resolved.

nikic commented Jul 20, 2022

nikic commented Jul 21, 2022

nikic commented Jul 22, 2022

tmandry commented Jul 22, 2022

rustbot commented Jul 22, 2022

bors commented Aug 12, 2022

bors commented Aug 12, 2022

rust-timer commented Aug 12, 2022

nnethercote commented Aug 12, 2022

Update to LLVM 15 #99464

Update to LLVM 15 #99464

Conversation

nikic commented Jul 19, 2022 • edited Loading

nikic commented Jul 19, 2022

rust-timer commented Jul 19, 2022

bors commented Jul 19, 2022

This comment has been minimized.

This comment has been minimized.

This comment was marked as resolved.

nikic commented Jul 19, 2022

rust-timer commented Jul 19, 2022

This comment has been minimized.

rust-timer commented Jul 19, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

This comment was marked as resolved.

nikic commented Jul 20, 2022

nikic commented Jul 21, 2022

nikic commented Jul 22, 2022

tmandry commented Jul 22, 2022

rustbot commented Jul 22, 2022

bors commented Aug 12, 2022

bors commented Aug 12, 2022

rust-timer commented Aug 12, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

nnethercote commented Aug 12, 2022

nikic commented Jul 19, 2022 •

edited

Loading