[perf experiment] Revert "Rollup merge of #99342 - TaKO8Ki:avoid-symbol-to-string-conve…

[matthiaskrgr]

…rsions, r=compiler-errors"

This reverts commit 6277ac2, reversing
changes made to 0c6e01b.

r? @ghost

[rustbot]

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in need_type_info.rs

cc @lcnr

[matthiaskrgr]

@bors try rust-timer queue

[matthiaskrgr]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 6537d39 with merge f5b5768a77119ca3933b67223782ef7a3b238bb1...

[bors]

☀️ Try build successful - checks-actions
Build commit: f5b5768a77119ca3933b67223782ef7a3b238bb1 (f5b5768a77119ca3933b67223782ef7a3b238bb1)

[rust-timer]

Queued f5b5768a77119ca3933b67223782ef7a3b238bb1 with parent 1cd72b7, future comparison URL.

[rust-timer]

Finished benchmarking commit (f5b5768a77119ca3933b67223782ef7a3b238bb1): comparison url.

Instruction count

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 😿 relevant regressions found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.3%	3.0%	6
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

• Primary benchmarks: 🎉 relevant improvement found
• Secondary benchmarks: 🎉 relevant improvements found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-2.0%	-2.0%	1
Improvements 🎉 (secondary)	-2.8%	-4.1%	9
All 😿🎉 (primary)	-2.0%	-2.0%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²