Rollup of 9 pull requests

[matthiaskrgr]

Successful merges:

• Fix rustdoc argument error #98331 (Fix rustdoc argument error)
• Fix span issues in object safety suggestions #98506 (Fix span issues in object safety suggestions)
• interpret: refactor allocation info query #98563 (interpret: refactor allocation info query)
• small regions refactoring #98576 (small regions refactoring)
• Fix "kind" for associated types in trait implementations in rustdoc JSON #98577 (Fix "kind" for associated types in trait implementations in rustdoc JSON)
• Remove eddyb from miri failure pings #98578 (Remove eddyb from miri failure pings)
• liballoc tests: avoid int2ptr cast #98579 (liballoc tests: avoid int2ptr cast)
• Add triagebot mentions. #98581 (Add triagebot mentions.)
• libcore tests: avoid int2ptr casts #98587 (libcore tests: avoid int2ptr casts)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[matthiaskrgr]

@bors r+ rollup=never p=9

[bors]

📌 Commit f266821 has been approved by matthiaskrgr

[bors]

⌛ Testing commit f266821 with merge 7f08d04...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 7f08d04 to master...

[rust-highfive]

📣 Toolstate changed by #98591!

Tested on commit 7f08d04.
Direct link to PR: #98591

💔 miri on windows: test-pass → build-fail (cc @RalfJung @oli-obk).
💔 miri on linux: test-pass → build-fail (cc @RalfJung @oli-obk).

[rust-timer]

Finished benchmarking commit (7f08d04): comparison url.

Instruction count

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 😿 relevant regressions found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	1.2%	1.7%	7
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

Max RSS (memory usage)

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	3.6%	4.2%	3
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-2.1%	-2.1%	2
All 😿🎉 (primary)	N/A	N/A	0

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²

[rylev]

It seems like #98576 is probably the only likely candidate for this regression.

@lcnr any thoughts on this? The cachegrind diff didn't reveal anything immediately interesting to me:

 -260,149,424  ???:<rustc_middle::ty::fold::RegionFolder as rustc_middle::ty::fold::FallibleTypeFolder>::try_fold_ty
  257,528,448  ???:<rustc_middle::ty::Ty as rustc_middle::ty::fold::TypeSuperFoldable>::super_fold_with::<rustc_middle::ty::fold::RegionFolder>
   67,497,361  ???:rustc_middle::ty::util::fold_list::<rustc_middle::ty::fold::RegionFolder, rustc_middle::ty::subst::GenericArg, <&rustc_middle::ty::list::List<rustc_middle::ty::subst::GenericArg> as rustc_middle::ty::fold::TypeFoldable>::try_fold_with<rustc_middle::ty::fold::RegionFolder>::{closure
  -38,998,821  ???:<&rustc_middle::ty::list::List<rustc_middle::ty::subst::GenericArg> as rustc_middle::ty::fold::TypeFoldable>::try_fold_with::<rustc_middle::ty::fold::RegionFolder>
   19,003,492  ???:<&rustc_middle::ty::list::List<rustc_middle::ty::Ty> as rustc_middle::ty::fold::TypeFoldable>::try_fold_with::<rustc_middle::ty::fold::RegionFolder>
   -6,228,826  ???:rustc_middle::ty::util::fold_list::<rustc_trait_selection::opaque_types::ReverseMapper, rustc_middle::ty::Ty, <&rustc_middle::ty::list::List<rustc_middle::ty::Ty> as rustc_middle::ty::fold::TypeFoldable>::try_fold_with<rustc_trait_selection::opaque_types::ReverseMapper>::{closure
    4,098,107  ???:<&rustc_middle::ty::list::List<rustc_middle::ty::Ty> as rustc_middle::ty::fold::TypeFoldable>::try_fold_with::<rustc_trait_selection::opaque_types::ReverseMapper>
   -3,605,392  ???:<rustc_middle::ty::fold::RegionFolder as rustc_middle::ty::fold::TypeFolder>::fold_region
    1,317,140  ???:<rustc_middle::ty::Ty as rustc_middle::ty::fold::TypeFoldable>::fold_with::<rustc_middle::ty::fold::RegionFolder>