Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #98494

Closed
wants to merge 30 commits into from

Commits on May 18, 2022

  1. Configuration menu
    Copy the full SHA
    fd76552 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. std: fix deadlock in Parker

    joboet committed May 19, 2022
    Configuration menu
    Copy the full SHA
    3b6ae15 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2022

  1. Configuration menu
    Copy the full SHA
    b9660de View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. std: relax memory orderings in Parker

    Co-authored-by: Tomoaki Kawada <kawada@kmckk.co.jp>
    joboet and kawadakk committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    caff723 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. On partial uninit error point at where we need init

    When a binding is declared without a value, borrowck verifies that all
    codepaths have *one* assignment to them to initialize them fully. If
    there are any cases where a condition can be met that leaves the binding
    uninitialized or we attempt to initialize a field of an unitialized
    binding, we emit E0381.
    
    We now look at all the statements that initialize the binding, and use
    them to explore branching code paths that *don't* and point at them. If
    we find *no* potential places where an assignment to the binding might
    be missing, we display the spans of all the existing initializers to
    provide some context.
    estebank committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    c238582 View commit details
    Browse the repository at this point in the history
  2. Tweak wording and spans

    estebank committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    a944456 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. Review comments: wording

    estebank committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    328522e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0e69340 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6eadf6e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cc4f804 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3eb9e1a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e4b2b41 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8495c64 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. Wording tweak

    estebank committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    6dd32f2 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. Configuration menu
    Copy the full SHA
    20cea3e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e80cced View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2022

  1. Configuration menu
    Copy the full SHA
    7475867 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    51552e7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    10ebfb7 View commit details
    Browse the repository at this point in the history
  4. Bump RLS to latest master on rust-lang/rls

    Of primary interest, this merges
    rust-lang/rls@ece09b8 into rust-lang/rust,
    which brings in the changes that fix RLS tests broken by rust-lang#97853. rust-lang#97853 already
    introduced that commit's changes (under
    27f4044df03d15c7c38a483c3e4635cf4f51807d) but without putting those changes on
    rust-lang/rls as a branch, so we ended up with an orphan commit that caused
    trouble when updating submodules in rust-lang/rust.
    
    This commit, once merged into rust-lang/rust, should continue to let RLS tests
    to pass on rust-lang/rust's side and move us back into a healthy state where tip
    of the submodule points to a valid master commit in the rust-lang/rls
    repository.
    Mark-Simulacrum committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    557793c View commit details
    Browse the repository at this point in the history
  5. fix: add compile target

    csmoe committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    7777dfd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    50a46b9 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#85673 - csmoe:export-exe-sym, r=bjorn3

    RFC-2841: add codegen flag export symbols from executable
    
    Closes rust-lang#84161
    r? `@nikomatsakis` `@Mark-Simulacrum`
    matthiaskrgr authored Jun 25, 2022
    Configuration menu
    Copy the full SHA
    67053d1 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#97140 - joboet:solid_parker, r=m-ou-se

    std: use an event-flag-based thread parker on SOLID
    
    `Mutex` and `Condvar` are being replaced by more efficient implementations, which need thread parking themselves (see rust-lang#93740). Therefore, the generic `Parker` needs to be replaced on all platforms where the new lock implementation will be used, which, after rust-lang#96393, are SOLID, SGX and Hermit (more PRs coming soon).
    
    SOLID, conforming to the [μITRON specification](http://www.ertl.jp/ITRON/SPEC/FILE/mitron-400e.pdf), has event flags, which are a thread parking primitive very similar to `Parker`. However, they do not make any atomic ordering guarantees (even though those can probably be assumed) and necessitate a system call even when the thread token is already available. Hence, this `Parker`, like the Windows parker, uses an extra atomic state variable.
    
    I future-proofed the code by wrapping the event flag in a `WaitFlag` structure, as both SGX and Hermit can share the Parker implementation, they just have slightly different primitives (SGX uses signals and Hermit has a thread blocking API (which is unfortunately [broken](hermit-os/kernel#442), I think).
    
    ```@kawadakk``` I assume you are the target maintainer? Could you test this for me?
    matthiaskrgr authored Jun 25, 2022
    Configuration menu
    Copy the full SHA
    a336ba5 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#97295 - c410-f3r:yet-another-let-chain, r=c…

    …ompiler-errors
    
    [rustc_parse] Forbid `let`s in certain places
    
    Currently only forbids in locals to resolve rust-lang#94927 (comment) but feel free to point any other places.
    matthiaskrgr authored Jun 25, 2022
    Configuration menu
    Copy the full SHA
    72da786 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#98297 - GuillaumeGomez:help-pocket-menu, r=…

    …notriddle
    
    Transform help popup into a pocket menu
    
    Just like we moved the settings menu into a "pocket menu", it's doing the same to the help popup.
    
    You can test it [here](https://rustdoc.crud.net/imperio/help-pocket-menu/doc/foo/index.html) and here is a screenshot:
    
    ![Screenshot from 2022-06-20 20-58-29](https://user-images.githubusercontent.com/3050060/174663718-538e9d11-3bf9-48b2-8909-f9bfe75af135.png)
    
    r? ````@jsha````
    matthiaskrgr authored Jun 25, 2022
    Configuration menu
    Copy the full SHA
    5c31d40 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#98360 - estebank:uninit-binding, r=oli-obk

     On partial uninit error point at where we need init
    
    When a binding is declared without a value, borrowck verifies that all
    codepaths have *one* assignment to them to initialize them fully. If
    there are any cases where a condition can be met that leaves the binding
    uninitialized or we attempt to initialize a field of an uninitialized
    binding, we emit E0381.
    
    We now look at all the statements that initialize the binding, and use
    them to explore branching code paths that *don't* and point at them. If
    we find *no* potential places where an assignment to the binding might
    be missing, we display the spans of all the existing initializers to
    provide some context.
    
    Fix rust-lang#97956.
    matthiaskrgr authored Jun 25, 2022
    Configuration menu
    Copy the full SHA
    308c8b8 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#98371 - compiler-errors:better-opaque-print…

    …ing, r=oli-obk
    
    Fix printing `impl trait` under binders
    
    Before, we would render `impl for<'a> Trait<'a>` like `impl Trait<for<'a> 'a>`, lol.
    matthiaskrgr authored Jun 25, 2022
    Configuration menu
    Copy the full SHA
    7097616 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#98488 - Mark-Simulacrum:bump-rls, r=pietroa…

    …lbini
    
    Bump RLS to latest master on rust-lang/rls
    
    Of primary interest, this merges
    rust-lang/rls@ece09b8 into rust-lang/rust,
    which brings in the changes that fix RLS tests broken by rust-lang#97853. rust-lang#97853 already
    introduced that commit's changes (under
    rust-lang/rls@27f4044) but without putting those changes on
    rust-lang/rls as a branch, so we ended up with an orphan commit that caused
    trouble when updating submodules in rust-lang/rust.
    
    This commit, once merged into rust-lang/rust, should continue to let RLS tests
    to pass on rust-lang/rust's side and move us back into a healthy state where tip
    of the submodule points to a valid master commit in the rust-lang/rls
    repository.
    
    cc rust-lang#98451, but not marking as fixed as I believe we need to add verification to prevent future oversights.
    matthiaskrgr authored Jun 25, 2022
    Configuration menu
    Copy the full SHA
    6bdce1d View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#98491 - antoyo:fix/ui-test-backtrace-panic-…

    …abort, r=Dylan-DPC
    
    Fix backtrace UI test when panic=abort is used
    
    The function `contains_verbose_expected` is only used when the panic strategy is not abort, so it caused a warning when it was abort, which made the UI test failed on stderr comparison.
    matthiaskrgr authored Jun 25, 2022
    Configuration menu
    Copy the full SHA
    3efe25f View commit details
    Browse the repository at this point in the history