Skip to content

net listen backlog set to negative on Linux.#97963

Merged
bors merged 1 commit intorust-lang:masterfrom
devnexen:net_listener_neg
Aug 20, 2022
Merged

net listen backlog set to negative on Linux.#97963
bors merged 1 commit intorust-lang:masterfrom
devnexen:net_listener_neg

Conversation

@devnexen
Copy link
Contributor

@devnexen devnexen commented Jun 10, 2022

it will be 4076 (from 5.4) or 128.

@devnexen
net listen backlog set to negative on Linux.
5454bca 
it will be 4076 (from 5.4) or 128.
@rust-highfive
Copy link
Contributor

rust-highfive commented Jun 10, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 10, 2022
@rust-highfive
Copy link
Contributor

rust-highfive commented Jun 10, 2022

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 10, 2022
the8472
the8472 reviewed Jun 28, 2022
View reviewed changes
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2022
@JohnTitor
Copy link
Member

JohnTitor commented Jul 25, 2022

r? @the8472

@rust-highfive rust-highfive assigned the8472 and unassigned kennytm Jul 25, 2022
@the8472 the8472 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2022
@devnexen
Copy link
Contributor Author

devnexen commented Aug 20, 2022

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 20, 2022
@the8472
Copy link
Member

the8472 commented Aug 20, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 20, 2022

📌 Commit 5454bca has been approved by the8472

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2022
@the8472
Copy link
Member

the8472 commented Aug 20, 2022

Potential followups if anyone is interested:

  • this could also be changed for FreeBSD since they explicitly document that -1 means the system default
  • other systems could maybe use libc::SOMAXCONN. I don't know why it was hardcoded to 128 before instead of using the platform definitions

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 20, 2022
@matthiaskrgr
Rollup merge of rust-lang#97963 - devnexen:net_listener_neg, r=the8472
fccc471 
net listen backlog set to negative on Linux.

it will be 4076 (from 5.4) or 128.
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 20, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 20, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 20, 2022
@bors
Auto merge of rust-lang#100810 - matthiaskrgr:rollup-xep778s, r=matth…
878aef7 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#97963 (net listen backlog set to negative on Linux.)
 - rust-lang#99935 (Reenable disabled early syntax gates as future-incompatibility lints)
 - rust-lang#100129 (add miri-test-libstd support to libstd)
 - rust-lang#100500 (Ban references to `Self` in trait object substs for projection predicates too.)
 - rust-lang#100636 (Revert "Revert "Allow dynamic linking for iOS/tvOS targets."")
 - rust-lang#100718 ([rustdoc] Fix item info display)
 - rust-lang#100769 (Suggest adding a reference to a trait assoc item)
 - rust-lang#100777 (elaborate how revisions work with FileCheck stuff in src/test/codegen)
 - rust-lang#100796 (Refactor: remove unnecessary string searchings)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d9789b6 into rust-lang:master Aug 20, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 20, 2022
devnexen added a commit to devnexen/rust that referenced this pull request Aug 21, 2022
@devnexen
net listen backlog update, follow-up from rust-lang#97963.
918258f 
FreeBSD and using system limit instead for others.
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Aug 22, 2022
@Dylan-DPC
Rollup merge of rust-lang#100835 - devnexen:listener_followups, r=dev…
de33a44 
…nexen

net listen backlog update, follow-up from rust-lang#97963.

FreeBSD and using system limit instead for others.
@Dylan-DPC Dylan-DPC mentioned this pull request Aug 22, 2022
Closed
devnexen added a commit to devnexen/rust that referenced this pull request Aug 22, 2022
@devnexen
net listen backlog update, follow-up from rust-lang#97963.
15c8e55 
FreeBSD and using system limit instead for others.
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Aug 23, 2022
@Dylan-DPC
Rollup merge of rust-lang#100835 - devnexen:listener_followups, r=dev…
a02511e 
…nexen

net listen backlog update, follow-up from rust-lang#97963.

FreeBSD and using system limit instead for others.
@Dylan-DPC Dylan-DPC mentioned this pull request Aug 23, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Aug 23, 2022
@Dylan-DPC
Rollup merge of rust-lang#100835 - devnexen:listener_followups, r=dev…
a163659 
…nexen

net listen backlog update, follow-up from rust-lang#97963.

FreeBSD and using system limit instead for others.
@Dylan-DPC Dylan-DPC mentioned this pull request Aug 23, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 23, 2022
@bors
Auto merge of rust-lang#100920 - Dylan-DPC:rollup-vlcw3sr, r=Dylan-DPC
a1bea15 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#99249 (Do not re-parse function signatures to suggest generics)
 - rust-lang#100309 (Extend comma suggestion to cases where fields arent missing)
 - rust-lang#100368 (InferCtxt tainted_by_errors_flag should be Option<ErrorGuaranteed>)
 - rust-lang#100768 (Migrate `rustc_plugin_impl` to `SessionDiagnostic`)
 - rust-lang#100835 (net listen backlog update, follow-up from rust-lang#97963.)
 - rust-lang#100851 (Fix rustc_parse_format precision & width spans)
 - rust-lang#100857 (Refactor query modifier parsing)
 - rust-lang#100907 (Fix typo in UnreachableProp)
 - rust-lang#100909 (Minor `ast::LitKind` improvements)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@asomers asomers mentioned this pull request Dec 14, 2023
Closed
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Dec 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@the8472 the8472 the8472 left review comments

Assignees

@the8472 the8472

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.65.0

Development

Successfully merging this pull request may close these issues.

8 participants

@devnexen @rust-highfive @JohnTitor @the8472 @bors @kennytm @JohnCSimon @rustbot