Rollup of 9 pull requests #97896
Merged
Rollup of 9 pull requests #97896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot do that for `&Vec` because `#[rustc_on_unimplemented]` is limited (it does not clean generic instantiation for references, only for ADTs).
…r=jackh726 Fix indices and remove some unwraps in arg mismatch algorithm This is a more conservative fix than rust-lang#97542, addressing some indices which were used incorectly and unwraps which are bound to panic (e.g. when the provided and expected arg counts differ). Beta nominating this as it's quite easy to cause ICEs -- I wrote a fuzzer and found hundreds of examples of ICEs. cc `@jackh726` as author of rust-lang#92364, and `@estebank` as reviewer of that PR. fixes rust-lang#97484 r? `@jackh726` this should be _much_ easier to review than the other PR 😅
Add std::alloc::set_alloc_error_hook example
…, r=estebank Don't suggest adding `let` in certain `if` conditions Avoid being too eager to suggest `let` in an `if` condition with an `=`, namely when the LHS of the `=` isn't even valid as a pattern (to a first degree approximation). This heustic I came up with kinda sucks. Let me know if it needs to be refined.
…, r=compiler-errors Suggest escaping `box` as identifier Fixes rust-lang#97810.
…emented, r=compiler-errors Suggest using `iter()` or `into_iter()` for `Vec` We cannot do that for `&Vec` because `#[rustc_on_unimplemented]` is limited (it does not clean generic instantiation for references, only for ADTs). `@rustbot` label +A-diagnostics
…rrors Add regresion test for rust-lang#67498 Closes rust-lang#67498 r? `@compiler-errors`
… r=jackh726 Remove `ignore-compare-mode-nll` annotations from tests Since rust-lang#95565 these do nothing as compare-mode-nll has been removed. r? `@jackh726`
Update books ## nomicon 5 commits in 10d40c59a581c66d8ecd29ad18d410bf97ed524d..3a43983b76174342b7dbd3e12ea2c49f762e52be 2022-05-07 10:45:07 +0900 to 2022-05-30 17:01:30 +0900 - Changes for `c_unwind` (rust-lang/nomicon#365) - Upgrade actions/checkout to v3 (rust-lang/nomicon#367) - Clarification of borrowck (rust-lang/nomicon#354) - Update the now stale warning about `PhantomData<T>` and dropck (rust-lang/nomicon#363) - Minor language fixes (rust-lang/nomicon#364) ## reference 1 commits in b74825d8f88b685e239ade00f00de68ba4cd63d4..683bfe5cd64d589c6a1645312ab5f93b6385ccbb 2022-05-20 14:30:30 -0700 to 2022-05-27 11:54:20 -0700 - Reflect changes about unsizing casts in const context (rust-lang/reference#1221) ## book 58 commits in b4dd5f00b87190ad5ef42cbc2a88a783c6ae57ef..396fdb69de7fb18f24b15c7ad13491b1c1fa7231 2022-05-24 21:37:06 -0400 to 2022-06-08 10:02:35 -0400 - Make not-equals operator example consistent. Fixes rust-lang/book#3189. - Propagate nostarch appendix edits to src - Edits to edits to appendices - Edits from nostarch for the appendices - Propagate edits to chapter 20 to src - Edits to edits of chapter 20 - Update reference to chapter 12 code that was changed - Edits from nostarch to chapter 20 - Fix spelling mistake - Propagate ch17 tech review changes to src - Responses to tech review for ch17 - Chapter 17 tech review comments - Update dependencies via `cargo update` - Propagate changes from ch16 tech review to src - Tech review comments and responses for chapter 16 - Println captures in chapter 15 - Propagate chapter 15 tech review edits to src - Responses to tech review for chapter 15 - Tech review comments for chapter 15 - Merge branch 'ch14-tr' - Upgrade to Rust 1.61 - Upgrade to Rust 1.60 - More little improvements to chapter 12 - Update references to ch12 to be Config::build instead of new - Propagate ch12 tech review edits to src - Responses to tech review of chapter 12 - Tech review comments of chapter 12 - Show directory layouts including integration test files - Clarify that integration/doc tests aren't run if unit tests fail - Propagate ch11 tech review edits to src - Edits in response to tech review of chapter 11 - Comments from tech review in chapter 11 - Propagate other edits to nostarch - Adjust listing so error output line numbers match - Merge remote-tracking branch 'origin/pr/3153' into ch10-tr - Reword a rewording about lifetimes of values vs references - Merge remote-tracking branch 'origin/pr/3107' into ch10-tr - Merge remote-tracking branch 'origin/pr/3104' into ch10-tr - Propagate ch10 edits to src - Edits in response to tech review - Comments from tech review for chapter 10 - New dictionary entries - Demonstrate a better expect message. Fixes rust-lang/book#2918. - Propagate tech review ch9 edits to src - Termination has stabilized! Fixes rust-lang/book#3116. - Respond to tech review comments to chapter 9 - Comments from tech review on chapter 9 - Propagate changes for ch8 to src - Clarify that split_whitespace returns an iterator - Add type annotation in nostarch snapshot too - Extra-clarity qualification - Edits to chapter 8 in response to tech review - Comments from tech review for chapter 8 - Propagate tech review edits to ch06 src - Responses to tech review comments on chapter 6 - Chapter 6 after tech review - Snapshot of chapter 1 for nostarch - src: use TLSv1.3 if we're going to specify at all ## rust-by-example 4 commits in 2ed26865e8c29ef939dc913a97bd321cadd72a9a..dbb7e5e2345ee26199ffba218156b6009016a20c 2022-05-18 17:23:47 -0300 to 2022-06-02 16:30:51 -0300 - Fix typo in Traits → "impl Trait" (rust-lang/rust-by-example#1544) - doc_testing.md: clarify tests vs doc-tests (rust-lang/rust-by-example#1547) - unsafe::asm.md: add some explicit declarations (rust-lang/rust-by-example#1548) - Update dsl.md to remove unnecessary braces (rust-lang/rust-by-example#1543) ## rustc-dev-guide 6 commits in 554c00e4805df7f7bffac7db408437d62d6dfb9a..6e4d6435db89bcc027b1bba9742e4f59666f5412 2022-05-24 17:15:35 -0700 to 2022-06-08 08:06:32 +0900 - Make build scripts and proc macros work with the suggested rust-analyzer config (rust-lang/rustc-dev-guide#1365) - improve rustc_interface examples a little (rust-lang/rustc-dev-guide#1362) - Bump regex from 1.4.3 to 1.5.5 in /ci/date-check (rust-lang/rustc-dev-guide#1364) - Clarify cargo fallback behavior for rustup link (rust-lang/rustc-dev-guide#1273) - Update rustc-driver related examples - Triage some date references related to traits ## embedded-book 1 commits in f7cefbb995eec8c6148f213235e9e2e03268e775..cbb494f96da3268c2925bdadc65ca83d42f2d4ef 2022-04-20 10:38:51 +0000 to 2022-05-26 06:58:43 +0000 - Add Chinese translation repository (rust-embedded/book#318)
…jackh726 Fix polonius compare mode. This fixes running compiler tests in `--compare-mode=polonius`. The `-Zborrowck=mir` option was removed in rust-lang#95565. r? `@jackh726`
rustbot
added
T-compiler
|
@bors r+ rollup=never p=9 |
|
📌 Commit cfc0677 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (15f5622): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesThis benchmark run did not return any relevant results for this metric. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
letin certainifconditions #97856 (Don't suggest addingletin certainifconditions)boxas identifier #97857 (Suggest escapingboxas identifier)iter()orinto_iter()forVec#97871 (Suggest usingiter()orinto_iter()forVec)ignore-compare-mode-nllannotations from tests #97883 (Removeignore-compare-mode-nllannotations from tests)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup