Recover import instead of use in item
#97819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
wesleywiser
approved these changes
Jun 7, 2022
compiler-errors
force-pushed
the
use-import
branch
from
ea2ed8c to
0252e00
Compare
compiler-errors
force-pushed
the
use-import
branch
from
0252e00 to
b7ed860
Compare
|
@bors r=wesleywiser rollup |
|
📌 Commit b7ed860 has been approved by |
bors
added
S-waiting-on-bors
|
Now what about dots instead of |
That would be a separate and more complicated recovery than what we currently have. Feel free to file an issue or take a stab if you're interested. |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 8, 2022
…ywiser
Recover `import` instead of `use` in item
When we definitely don't have a macro invocation (i.e. when we don't have `import ::`), then it's more productive to parse `import` as if it was incorrectly mistaken for `use`.
Not sure if this needs to be a verbose suggestion, but it renders strangely when it's not verbose:
```
error: expected item, found `import`
--> /home/michael/test.rs:1:1
|
1 | import std::{io::{self, Write}, rc::Rc};
| ^^^^^^ help: items are imported using the `use` keyword: `use`
```
Happy to change it to `span_suggestion` instead of `span_suggestion_verbose` though.
Fixes rust-lang#97788
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 8, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#97595 (Remove unwrap from get_vtable) - rust-lang#97597 (Preserve unused pointer to address casts) - rust-lang#97819 (Recover `import` instead of `use` in item) - rust-lang#97823 (Recover missing comma after match arm) - rust-lang#97851 (Use repr(C) when depending on struct layout in ptr tests) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we definitely don't have a macro invocation (i.e. when we don't have
import ::), then it's more productive to parseimportas if it was incorrectly mistaken foruse.Not sure if this needs to be a verbose suggestion, but it renders strangely when it's not verbose:
Happy to change it to
span_suggestioninstead ofspan_suggestion_verbosethough.Fixes #97788