Skip to content

Conversation

@compiler-errors
Copy link
Member

r? @estebank

Closes #89137 for good, I think

Not sure if this is what you were looking for in #89137 (comment)

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 4, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 4, 2022
@Dylan-DPC
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 4, 2022

📌 Commit 4c6a6bc has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2022
@JohnTitor
Copy link
Member

Not sure if this is what you were looking for in #89137 (comment)

@Dylan-DPC Reading this comment, I guess @compiler-errors wanted to confirm it to @estebank.

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 4, 2022
Rollup of 5 pull requests

Successful merges:

 - rust-lang#96642 (Avoid zero-sized allocs in ThinBox if T and H are both ZSTs.)
 - rust-lang#97647 (Lazily allocate and initialize pthread locks.)
 - rust-lang#97715 (Support the `#[expect]` attribute on fn parameters (RFC-2383))
 - rust-lang#97716 (Fix reachability analysis for const methods)
 - rust-lang#97722 (Tighten spans for bad fields in struct deriving `Copy`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@compiler-errors
Copy link
Member Author

Yes, @JohnTitor is correct.

@Dylan-DPC, please be careful about r+'ing PRs that might need or want review from specific people, regardless of the size of the PR.

@Dylan-DPC
Copy link
Member

sure looked trivial enough :P and any changes can be made over it later without much disruption :)

@bors bors merged commit 8c4c698 into rust-lang:master Jun 4, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 4, 2022
@JohnTitor
Copy link
Member

sure looked trivial enough :P and any changes can be made over it later without much disruption :)

It does mean we have to make another PR and the master branch would have a possible wrong change until another change lands, though. Any urgent PRs will be handled by the relevant team in general so you don't have to rush r+'ing PRs, I think.

@compiler-errors compiler-errors deleted the tighten-copy-type-error-spans branch August 11, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show error E0277 when the trait bound of a struct's member's type is unsatisfied even if E0204 is also present

7 participants