Revert diagnostic duplication and accidental stabilization #96516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
added
beta-nominated
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @compiler-errors from the github reviewer suggestions |
oli-obk
removed
the
beta-accepted
|
@bors r+ |
|
📌 Commit d22c439 has been approved by |
bors
added
S-waiting-on-bors
rustbot
added
the
beta-accepted
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 29, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#96477 (Update data layout string for wasm64-unknown-unknown) - rust-lang#96481 (HashMap doc: Don't use monospace font for 'Entry Api') - rust-lang#96492 (Revert "Re-export core::ffi types from std::ffi") - rust-lang#96516 (Revert diagnostic duplication and accidental stabilization) - rust-lang#96523 (Add ``@feat.00`` symbol to symbols.o for COFF) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
ehuss
pushed a commit
to ehuss/rust
that referenced
this pull request
May 4, 2022
…ntal_permitted, r=jackh726 Revert diagnostic duplication and accidental stabilization fixes rust-lang#96460 this is an accidental stabilization that we should put into the beta. I believe it is low-risk, because it was literally what we had before rust-lang#94081 The effect on tests is massive, but mostly deduplication of diagnostics and some minor span changes.
Merged
ehuss
removed
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 4, 2022
[beta] Beta backports * Revert diagnostic duplication and accidental stabilization rust-lang#96516 * Revert "Re-export core::ffi types from std::ffi" rust-lang#96492 * Make [e]println macros eagerly drop temporaries (for backport) rust-lang#96490 * Revert "impl From<&[T; N]> and From<&mut [T; N]> for Vec<T>" rust-lang#96489 * Cargo: * move workspace inheritance unstable docs to the correct place (rust-lang/cargo#10616)
MabezDev
pushed a commit
to esp-rs/rust
that referenced
this pull request
May 17, 2022
…ntal_permitted, r=jackh726 Revert diagnostic duplication and accidental stabilization fixes rust-lang#96460 this is an accidental stabilization that we should put into the beta. I believe it is low-risk, because it was literally what we had before rust-lang#94081 The effect on tests is massive, but mostly deduplication of diagnostics and some minor span changes.
This was referenced May 26, 2022
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
May 30, 2022
don't do `Sized` and other return type checks on RPIT's real type Fixes an ICE where we're doing `Sized` check against the RPIT's real type, instead of against the opaque type. This differs from what we're doing in MIR typeck, which causes ICE rust-lang#97226. This regressed in rust-lang#96516 -- this adjusts that fix to be a bit more conservative. That PR was backported and thus the ICE is also present in stable. Not sure if it's worth to beta and/or stable backport, probably not the latter but I could believe the former. r? `@oli-obk` cc: another attempt to fix this ICE rust-lang#97413. I believe this PR addresses the root cause.
ehuss
pushed a commit
to ehuss/rust
that referenced
this pull request
Jun 24, 2022
don't do `Sized` and other return type checks on RPIT's real type Fixes an ICE where we're doing `Sized` check against the RPIT's real type, instead of against the opaque type. This differs from what we're doing in MIR typeck, which causes ICE rust-lang#97226. This regressed in rust-lang#96516 -- this adjusts that fix to be a bit more conservative. That PR was backported and thus the ICE is also present in stable. Not sure if it's worth to beta and/or stable backport, probably not the latter but I could believe the former. r? `@oli-obk` cc: another attempt to fix this ICE rust-lang#97413. I believe this PR addresses the root cause.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #96460
this is an accidental stabilization that we should put into the beta. I believe it is low-risk, because it was literally what we had before #94081
The effect on tests is massive, but mostly deduplication of diagnostics and some minor span changes.