Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #96263

Merged
merged 38 commits into from
Apr 21, 2022
Merged

Rollup of 5 pull requests #96263

merged 38 commits into from
Apr 21, 2022

Commits on Apr 18, 2022

  1. Configuration menu
    Copy the full SHA
    be41750 View commit details
    Browse the repository at this point in the history
  2. Update search engine and parser to error when quotes are used on quer…

    …ies with more than one element.
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    3aeef67 View commit details
    Browse the repository at this point in the history
  3. Update tests

    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    0f51652 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7cefee0 View commit details
    Browse the repository at this point in the history
  5. Add parser tests

    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    f5833e7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bbcf176 View commit details
    Browse the repository at this point in the history
  7. * If type filter is in quotes, throw an error.

    * If there are generics, don't allow to have quotes.
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    51de26c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    99c5394 View commit details
    Browse the repository at this point in the history
  9. * Greatly improve the rustdoc search parser source code

    * Move all functions outside parseQuery
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    264064d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    99d5520 View commit details
    Browse the repository at this point in the history
  11. Simplify parser syntax

    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    4929733 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    c7de1a1 View commit details
    Browse the repository at this point in the history
  13. Apply suggestions:

     * Forbid generics without a path (so "<p>" is forbidden).
     * Change `handleSingleArg` so that it takes `results_others`, `results_in_args` and `results_returned` as arguments instead of using the "global" variables.
     * Change `createQueryElement` so that it returns the newly created element instead of taking `elems` as argument.
     * Improve documentation
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    699ae36 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    f9251ee View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    8e29ed4 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    1f5c4c2 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    da829d8 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    e03a950 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    51b4005 View commit details
    Browse the repository at this point in the history
  20. Add tests for paths

    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    ab9cf32 View commit details
    Browse the repository at this point in the history
  21. Remove unnecessary elem.name.length === 0 since the rustdoc search …

    …eBNF does not allow elements without a name
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    a6051c7 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    6f35475 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    da363b2 View commit details
    Browse the repository at this point in the history
  24. Fix some corner cases

    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    d7d538a View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    299e8ee View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    5c6c1e1 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    8d0e10c View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. Remove assertion that all paths in ShouldRun exist

    This breaks on submodules (see rust-lang#96188). Disable the assertion for now until I can think of a proper
    fix.
    
    This doesn't revert any of the changes in `Step`s themselves, only what
    `ShouldRun::paths` does.
    jyn514 committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    b4ca065 View commit details
    Browse the repository at this point in the history
  2. [fuchsia] Add implementation for current_exe

    This implementation returns a best attempt at the current exe path. On
    fuchsia, fdio will always use `argv[0]` as the process name and if it is
    not set then an error will be returned. Because this is not guaranteed
    to be the case, this implementation returns an error if `argv` does not
    contain any elements.
    David Koloski committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    eb6b6a8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    671a872 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. Configuration menu
    Copy the full SHA
    4879875 View commit details
    Browse the repository at this point in the history
  2. Add an explicit Span field to OutlivesConstraint

    Previously, we would retrieve the span from the `Body` using
    the `locations` field. However, we may end up changing the
    `locations` field when moving a constraint from a promoted
    to a different body.
    
    We now store the original `Span` in a dedication field, so that
    changes to the `locations` do not affect the quality of our
    diagnostics.
    Aaron1011 committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    611a06a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4d26bde View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#90630 - GuillaumeGomez:improve-rustdoc-sear…

    …ch, r=notriddle
    
    Create real parser for search queries
    
    You can test it [here](https://rustdoc.crud.net/imperio/improve-rustdoc-search/std/index.html).
    
    This PR adds a real parser for the query engine in rustdoc. The parser is quite simple but it allows to makes query handling much easier. I added a new testsuite to ensure it works as expected and ran fuzzing checks on it for a few hours without problems.
    
    So about the parser: as you can see in the screenshot, it handles recursive generics parsing. It also allows to set which item should use exact matching by adding double-quotes around it (look for `exact_search` in the screenshot).
    
    Now about the query engine itself: I simplified it a lot thanks to the parsed query. It behaves mostly the same when there is only one argument, but is much more powerful when there are more than one.
    
    When making this change, we also removed the support for multi-query.
    
    PS: A big part of the PR is tests and test-related code. :)
    
    r? `@camelid`
    Dylan-DPC authored Apr 20, 2022
    Configuration menu
    Copy the full SHA
    976c6b2 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#96193 - djkoloski:fuchsia_current_exe, r=tm…

    …andry
    
    [fuchsia] Add implementation for `current_exe`
    
    This implementation returns a best attempt at the current exe path. On
    fuchsia, fdio will always use `argv[0]` as the process name and if it is
    not set then an error will be returned. Because this is not guaranteed
    to be the case, this implementation returns an error if `argv` does not
    contain any elements.
    Dylan-DPC authored Apr 20, 2022
    Configuration menu
    Copy the full SHA
    1e43aae View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#96196 - jyn514:no-assertion, r=Mark-Simulacrum

    Remove assertion that all paths in `ShouldRun` exist
    
    This breaks on submodules (see rust-lang#96188). Disable the assertion for now until I can think of a proper
    fix.
    
    This doesn't revert any of the changes in `Step`s themselves, only what
    `ShouldRun::paths` does.
    Dylan-DPC authored Apr 20, 2022
    Configuration menu
    Copy the full SHA
    0179aac View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#96228 - mbartlett21:patch-4, r=thomcc

    Fix locations for intrinsics impls and change to links
    
    These still referred to `rustc_mir`.
    Dylan-DPC authored Apr 20, 2022
    Configuration menu
    Copy the full SHA
    e2543d7 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#96236 - Aaron1011:constraint-debug, r=jackh726

    Add an explicit `Span` field to `OutlivesConstraint`
    
    Previously, we would retrieve the span from the `Body` using
    the `locations` field. However, we may end up changing the
    `locations` field when moving a constraint from a promoted
    to a different body.
    
    We now store the original `Span` in a dedication field, so that
    changes to the `locations` do not affect the quality of our
    diagnostics.
    Dylan-DPC authored Apr 20, 2022
    Configuration menu
    Copy the full SHA
    463c94a View commit details
    Browse the repository at this point in the history