Skip to content

Conversation

clarfonthey
Copy link
Contributor

@clarfonthey clarfonthey commented Apr 16, 2022

  • Links MaybeUninit::uninit_array to meta-tracking issue
  • Links MaybeUninit::array_assume_init to meta-tracking issue
  • Unstably constifies MaybeUninit::array_assume_init

Another thing worth mentioning: this splits the const feature flag for maybe_uninit_uninit_array into const_maybe_uninit_uninit_array to avoid weird cases where only one gets stabilised.

Note that it may be desired to keep the array_assume_init method linked to its dedicated issue, but at least for now, I decided to link to the meta-tracking issue so that all of the methods lead users to the same place. But I can revert that bit if desired.

The meta-tracking issue that I filed is #96097.

* Links MaybeUninit::uninit_array to meta-tracking issue
* Links MaybeUninit::array_assume_init to meta-tracking issue
* Unstably constifies MaybeUninit::array_assume_init
@rust-highfive
Copy link
Contributor

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 16, 2022
@rust-highfive
Copy link
Contributor

r? @thomcc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2022
@thomcc
Copy link
Member

thomcc commented Apr 16, 2022

This unstably constifies a function, so

r? rust-lang/libs-api @rustbot label +T-libs-api -T-lib

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Apr 16, 2022
@rust-highfive rust-highfive assigned dtolnay and unassigned thomcc Apr 16, 2022
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dtolnay
Copy link
Member

dtolnay commented Apr 16, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 16, 2022

📌 Commit 63a8652 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 16, 2022
Rollup of 9 pull requests

Successful merges:

 - rust-lang#93969 (Only add codegen backend to dep info if -Zbinary-dep-depinfo is used)
 - rust-lang#94605 (Add missing links in platform support docs)
 - rust-lang#95372 (make unaligned_references lint deny-by-default)
 - rust-lang#95859 (Improve diagnostics for unterminated nested block comment)
 - rust-lang#95961 (implement SIMD gather/scatter via vector getelementptr)
 - rust-lang#96004 (Consider lifetimes when comparing types for equality in MIR validator)
 - rust-lang#96050 (Remove some now-dead code that was only relevant before deaggregation.)
 - rust-lang#96070 ([test] Add test cases for untested functions for BTreeMap)
 - rust-lang#96099 (MaybeUninit array cleanup)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f559cf9 into rust-lang:master Apr 16, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 16, 2022
@clarfonthey clarfonthey deleted the maybeuninit_array_cleanup branch April 16, 2022 18:41
yvt added a commit to r3-os/r3 that referenced this pull request Apr 21, 2022
The `const`-ness of `MaybeUninit::uninit_array` has been split into a
separate feature by [rust-lang/rust#96099][1].

[1]: rust-lang/rust#96099
yvt added a commit to r3-os/r3 that referenced this pull request Apr 23, 2022
The `const`-ness of `MaybeUninit::uninit_array` has been split into a
separate feature by [rust-lang/rust#96099][1].

[1]: rust-lang/rust#96099
yvt added a commit to r3-os/r3 that referenced this pull request May 23, 2022
This feature, which covers the `const fn` version of `MaybeUninit::
array_assume_init`, was added by [rust-lang/rust#96099][1].

[1]: rust-lang/rust#96099
yvt added a commit to r3-os/r3 that referenced this pull request May 24, 2022
This feature, which covers the `const fn` version of `MaybeUninit::
array_assume_init`, was added by [rust-lang/rust#96099][1].

[1]: rust-lang/rust#96099
yvt added a commit to r3-os/r3 that referenced this pull request May 24, 2022
This feature, which covers the `const fn` version of `MaybeUninit::
array_assume_init`, was added by [rust-lang/rust#96099][1].

[1]: rust-lang/rust#96099
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants