Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that DirEntry holds the directory open #95962

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Document that DirEntry holds the directory open #95962

merged 1 commit into from
Apr 13, 2022

Conversation

sourcefrog
Copy link
Contributor

I had a bug where holding onto DirEntry structs caused file descriptor exhaustion, and thought it would be good to document this.

@rust-highfive
Copy link
Collaborator

Thank you for submitting a new PR for the library teams! If this PR contains a stabilization of a library feature that has not already completed FCP in its tracking issue, introduces new or changes existing unstable library APIs, or changes our public documentation in ways that create new stability guarantees then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary

@rust-highfive
Copy link
Collaborator

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2022
@Dylan-DPC
Copy link
Member

@bors r+ rollup

1 similar comment
@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 13, 2022

📌 Commit 7cdef08 has been approved by Dylan-DPC

1 similar comment
@bors
Copy link
Contributor

bors commented Apr 13, 2022

📌 Commit 7cdef08 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 13, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 13, 2022
@bors
Auto merge of rust-lang#96015 - Dylan-DPC:rollup-vhdprid, r=Dylan-DPC
0d13f6a 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#93217 (Improve Rustdoc UI for scraped examples with multiline arguments, fix overflow in line numbers)
 - rust-lang#95885 (Improve error message in case of missing checksum)
 - rust-lang#95962 (Document that DirEntry holds the directory open)
 - rust-lang#95991 (fix: wrong trait import suggestion for T:)
 - rust-lang#96005 (Add missing article to fix "few" to "a few".)
 - rust-lang#96006 (Add a missing article)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 032358b into rust-lang:master Apr 13, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 13, 2022
@sourcefrog sourcefrog deleted the doc-direntry branch April 14, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
6 participants
@sourcefrog @rust-highfive @Dylan-DPC @bors @m-ou-se @rustbot