Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neither require nor imply lifetime bounds on opaque type for well formedness #95474

Merged
merged 18 commits into from
Sep 25, 2022
Merged

Neither require nor imply lifetime bounds on opaque type for well formedness #95474

merged 18 commits into from
Sep 25, 2022

Commits on Sep 21, 2022

  1. Split match out into a helper function

    @oli-obk
    oli-obk committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    3d69d23 View commit details
    Browse the repository at this point in the history

  2. Some tracing instrumentation cleanups

    @oli-obk
    oli-obk committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    759c04a View commit details
    Browse the repository at this point in the history

  3. Inline a trivial function

    @oli-obk
    oli-obk committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    96b819a View commit details
    Browse the repository at this point in the history

  4. Generalize a helper to be useful for types other than projections

    @oli-obk
    oli-obk committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    4d4cc4f View commit details
    Browse the repository at this point in the history

  5. Generalize projection_must_outlive

    @oli-obk
    oli-obk committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    c8ecf09 View commit details
    Browse the repository at this point in the history

  6. Neither require nor imply lifetime bounds on opaque type for well for… 

    …medness
    @oli-obk
    oli-obk committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    37928f5 View commit details
    Browse the repository at this point in the history

  7. Also collect bounds from the ParamEnv for opaque types

    @oli-obk
    oli-obk committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    90b6744 View commit details
    Browse the repository at this point in the history

  8. Add regression test

    @oli-obk
    oli-obk committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    a8c9784 View commit details
    Browse the repository at this point in the history

  9. Inline substitution logic into declared_region_bounds

    @oli-obk
    oli-obk committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    615c9e8 View commit details
    Browse the repository at this point in the history

  10. Simplify insert_outlives_predicate opaque type logic

    @oli-obk
    oli-obk committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    20d962c View commit details
    Browse the repository at this point in the history

  11. Try out a perf optimization

    @oli-obk
    oli-obk committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    36cb01d View commit details
    Browse the repository at this point in the history

  12. Reproduce sad diagnostic

    @oli-obk
    oli-obk committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    4b323e6 View commit details
    Browse the repository at this point in the history

  13. Improve diagnostic for adding more bounds to opaque types

    @oli-obk
    oli-obk committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    86f1ca8 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. Showcase a broken diagnostic

    @oli-obk
    oli-obk committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    5ace12c View commit details
    Browse the repository at this point in the history

  2. Show errors instead of hiding them due to an earlier error

    @oli-obk
    oli-obk committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    90ec6f8 View commit details
    Browse the repository at this point in the history

  3. Make the test actually show the problematic case

    @oli-obk
    oli-obk committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    e9d219e View commit details
    Browse the repository at this point in the history

  4. Some test cleanups

    @oli-obk
    oli-obk committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    e237aae View commit details
    Browse the repository at this point in the history

  5. Report diagnostics at the actually actionable site

    @oli-obk
    oli-obk committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    59e285f View commit details
    Browse the repository at this point in the history