Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show ignore message in console and json output #94566

Merged
merged 4 commits into from
Mar 29, 2022
Merged

Show ignore message in console and json output #94566

merged 4 commits into from
Mar 29, 2022

Conversation

yanganto
Copy link
Contributor

@yanganto yanganto commented Mar 3, 2022

  • Provide ignore the message in console and JSON output
  • Modify the ignore message style in the log file

related: #92714

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 3, 2022
@yanganto
Copy link
Contributor Author

yanganto commented Mar 3, 2022

r?@Mark-Simulacrum

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@yanganto yanganto force-pushed the show-ignore-message branch from 113fab8 to 2162d7a Compare March 3, 2022 16:49
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@yanganto yanganto force-pushed the show-ignore-message branch from 2162d7a to 5d4f681 Compare March 3, 2022 16:59
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@yanganto yanganto force-pushed the show-ignore-message branch from 5d4f681 to 3b5ecaa Compare March 3, 2022 17:25
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@yanganto yanganto force-pushed the show-ignore-message branch from 3b5ecaa to b02db87 Compare March 3, 2022 17:43
@yanganto yanganto marked this pull request as ready for review March 3, 2022 18:17
@yanganto
Copy link
Contributor Author

yanganto commented Mar 4, 2022

Hi @m-ou-se,
it may not be good and waste rust developing power to have more than one experience member to take a look at one thing. It is just a kindly notice to let you know it is fixing and I really thank you for the thing to check after the previous PR goes into nightly. That is the thing I should do. 🙏 ❤️

@yanganto
Copy link
Contributor Author

Hi @Mark-Simulacrum, do you have any concerns about this? The ignore message will show as we think on the summary of cargo test. If there is still something missing, please let me know. Thanks.

@bors
Copy link
Contributor

bors commented Mar 11, 2022

☔ The latest upstream changes (presumably #94824) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum
Copy link
Member

I plan to review it soon, just haven't had the chance to yet.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 11, 2022
@Mark-Simulacrum
Copy link
Member

r? @m-ou-se since I authored the test cases here -- was going to offer some mentoring instructions but ended up finishing the work. There's probably a nice cleanup project to unify some of the test cases, and we might want to drop --logfile now that the JSON output mode exists.

@yanganto
Copy link
Contributor Author

yanganto commented Mar 17, 2022 •
edited
Loading

@m-ou-se If there is something I can do, please let me know, I am willing to help. :)

m-ou-se
m-ou-se reviewed Mar 28, 2022
View reviewed changes
Copy link
Member

@m-ou-se m-ou-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good. I left a few small comments.

library/test/src/formatters/pretty.rs Outdated Show resolved Hide resolved
library/test/src/formatters/json.rs Outdated Show resolved Hide resolved
library/test/src/formatters/pretty.rs Outdated Show resolved Hide resolved
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@yanganto yanganto force-pushed the show-ignore-message branch from 3564249 to 80f191f Compare March 29, 2022 11:50
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@yanganto @m-ou-se
Refactor after review
3a0ae49 
Co-authored-by: Mara Bos <m-ou.se@m-ou.se>
@yanganto yanganto force-pushed the show-ignore-message branch from 3dbf021 to 3a0ae49 Compare March 29, 2022 12:34
@yanganto
Copy link
Contributor Author

@m-ou-se Thanks for the review. The PR is ready. 😃

@m-ou-se
Copy link
Member

m-ou-se commented Mar 29, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Mar 29, 2022

📌 Commit b1c3494 has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 29, 2022
@Dylan-DPC
Rollup merge of rust-lang#94566 - yanganto:show-ignore-message, r=m-o…
1830e8f 
…u-se

Show ignore message in console and json output

- Provide ignore the message in console and JSON output
- Modify the ignore message style in the log file

related: rust-lang#92714
@Dylan-DPC Dylan-DPC mentioned this pull request Mar 29, 2022
Merged
@bors
Copy link
Contributor

bors commented Mar 29, 2022

⌛ Testing commit b1c3494 with merge 05d2221...

@bors
Copy link
Contributor

bors commented Mar 29, 2022

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing 05d2221 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 29, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 29, 2022
@bors
Auto merge of rust-lang#95433 - Dylan-DPC:rollup-xdfit9h, r=Dylan-DPC
5e1d19d 
Rollup of 4 pull requests

Successful merges:

 - rust-lang#94566 (Show ignore message in console and json output)
 - rust-lang#95415 (diagnostics: regression test for HashMap iter_mut suggestion)
 - rust-lang#95422 (Refactor: Use `format-args-capture` and remove an unnecessary nested block)
 - rust-lang#95424 (:arrow_up: rust-analyzer)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 05d2221 into rust-lang:master Mar 29, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 29, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (05d2221): comparison url.

Summary: This benchmark run did not return any relevant results. 4 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-ou-se m-ou-se m-ou-se left review comments

Assignees

@m-ou-se m-ou-se

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
9 participants
@yanganto @rust-highfive @rust-log-analyzer @bors @Mark-Simulacrum @m-ou-se @rust-timer @kennytm @rustbot