Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump libc and fix remove_dir_all on Fuchsia after CVE fix #93351

Merged
merged 1 commit into from
Jan 29, 2022

Commits on Jan 28, 2022

  1. Fix remove_dir_all on Fuchsia after CVE fix.

    With the previous `is_dir` impl, we would attempt to unlink
    a directory in the None branch, but Fuchsia supports returning
    ENOTEMPTY from unlinkat() without the AT_REMOVEDIR flag because
    we don't currently differentiate unlinking files and directories
    by default.
    
    On the Fuchsia side I've opened https://fxbug.dev/92273 to discuss
    whether this is the correct behavior, but it doesn't seem like
    addressing the error code is necessary to make our tests happy.
    
    Updates std's libc crate to include DT_UNKNOWN for Fuchsia.
    anp authored and tmandry committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    8c9944c View commit details
    Browse the repository at this point in the history