Skip to content

Document Box<T> FFI guarantee in 1.41.0 release notes #92506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2022
Merged

Document Box<T> FFI guarantee in 1.41.0 release notes #92506

merged 1 commit into from
Jan 12, 2022

Conversation

@nico-abram
Copy link
Contributor

@nico-abram nico-abram commented Jan 3, 2022

Fixes #68676

@rust-highfive
Copy link
Contributor

rust-highfive commented Jan 3, 2022

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 3, 2022
Mark-Simulacrum
Mark-Simulacrum reviewed Jan 5, 2022
View reviewed changes
@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2022
@nico-abram
Copy link
Contributor Author

nico-abram commented Jan 5, 2022

@rustbot label -S-waiting-on-author +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 5, 2022
@camelid camelid added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Jan 5, 2022
camelid
camelid reviewed Jan 5, 2022
View reviewed changes
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jan 10, 2022

@bors r+ rollup

Squashed commits.

@bors
Copy link
Collaborator

bors commented Jan 10, 2022

📌 Commit fc8af98 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 11, 2022
@matthiaskrgr
Rollup merge of rust-lang#92506 - nico-abram:uwu, r=Mark-Simulacrum
1d97d61 
Document Box<T> FFI guarantee in 1.41.0 release notes

Fixes rust-lang#68676
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 11, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 11, 2022
@matthiaskrgr
Rollup merge of rust-lang#92506 - nico-abram:uwu, r=Mark-Simulacrum
df59daf 
Document Box<T> FFI guarantee in 1.41.0 release notes

Fixes rust-lang#68676
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 11, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 12, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 12, 2022
@bors
Auto merge of rust-lang#92811 - matthiaskrgr:rollup-wrctcef, r=matthi…
1bd4fdc 
…askrgr

Rollup of 14 pull requests

Successful merges:

 - rust-lang#92328 (Tweak sentence in `transmute` docs)
 - rust-lang#92432 (Error when selected impl is not const in constck)
 - rust-lang#92506 (Document Box<T> FFI guarantee in 1.41.0 release notes)
 - rust-lang#92699 (rustdoc: Display "private fields" instead of "fields omitted")
 - rust-lang#92703 (RELEASES.md: Add 1.58 release note for `File::options` stabilization)
 - rust-lang#92707 (Extended the note on the use of `no_run` attribute)
 - rust-lang#92709 (Improve documentation for File::options to give a more likely example)
 - rust-lang#92720 (Fix doc formatting for time.rs)
 - rust-lang#92732 (Add note about upstream commit musl-patch-configure.diff is derived from)
 - rust-lang#92742 (Add missing suffix for sidebar-items script path)
 - rust-lang#92748 (Eliminate "boxed" wording in `std::error::Error` documentation)
 - rust-lang#92754 (Update AsmArgs field visibility for rustfmt)
 - rust-lang#92756 (:arrow_up: rust-analyzer)
 - rust-lang#92764 (Fix rust logo style)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9ea9e18 into rust-lang:master Jan 12, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

@camelid camelid camelid left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.60.0

Development

Successfully merging this pull request may close these issues.

rust/RELEASES.md doesn't list the Box<T> FFI change for 1.41.0

6 participants

@nico-abram @rust-highfive @Mark-Simulacrum @bors @camelid @rustbot