switch Drop to &mut self
#9244
Merged
switch Drop to &mut self
#9244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -187,7 +187,7 @@ impl UvEventLoop { | |||
| } | |||
|
|
|||
| impl Drop for UvEventLoop { | |||
| fn drop(&self) { | |||
| fn drop(&mut self) { | |||
| // XXX: Need mutable finalizer | |||
| let this = unsafe { | |||
| transmute::<&UvEventLoop, &mut UvEventLoop>(self) | |||
There was a problem hiding this comment.
Seems this transmute is no longer necessary with this change? Also true for a lot of other lines below.
There was a problem hiding this comment.
Yeah, missed that one.
bors
added a commit
that referenced
this pull request
Sep 17, 2013
This doesn't close any bugs as the goal is to convert the parameter to by-value, but this is a step towards being able to make guarantees about `&T` pointers (where T is Freeze) to LLVM.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 28, 2022
Fix ICE in `question_mark` fixes rust-lang#9242 changelog: [`question_mark`](https://rust-lang.github.io/rust-clippy/master/#question_mark): Fix ICE on zero field tuple structs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't close any bugs as the goal is to convert the parameter to by-value, but this is a step towards being able to make guarantees about
&Tpointers (where T is Freeze) to LLVM.