Some cleanups around check_argument_types #92360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
jackh726
force-pushed
the
param-heuristics-1
branch
from
e09d2bf to
bbb8bde
Compare
davidtwco
approved these changes
Jan 5, 2022
|
Apologies for the delay in getting to this review. @bors r+ |
|
📌 Commit bbb8bde has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 5, 2022
…dtwco Some cleanups around check_argument_types Split out in ways from my rebase/continuation of rust-lang#71827 Commits are mostly self-explanatory and these changes should be fairly straightforward
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 5, 2022
…dtwco Some cleanups around check_argument_types Split out in ways from my rebase/continuation of rust-lang#71827 Commits are mostly self-explanatory and these changes should be fairly straightforward
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 6, 2022
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#92058 (Make Run button visible on hover) - rust-lang#92288 (Fix a pair of mistyped test cases in `std::net::ip`) - rust-lang#92349 (Fix rustdoc::private_doc_tests lint for public re-exported items) - rust-lang#92360 (Some cleanups around check_argument_types) - rust-lang#92389 (Regression test for borrowck ICE rust-lang#92015) - rust-lang#92404 (Fix font size for [src] links in headers) - rust-lang#92443 (Rustdoc: resolve associated traits for non-generic primitive types) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 7, 2022
…dtwco Check extra function arg exprs even if the fn is not C-variadic We should still call check_expr on the args that exceed the formal input ty count, so that we have expr types to emit during writeback. Not sure where this regressed, but it wasn't due to the same root cause as rust-lang#94334 I think. I thought this might've regressed in rust-lang#92360, but I think that is in stable, ad the test I provided (which minimizes rust-lang#94599) passes on stable in playground. Maybe it regressed in rust-lang#93118. Anywho, fixes rust-lang#94599.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 16, 2022
…euristics, r=estebank Better method call error messages Rebase/continuation of rust-lang#71827 ~Based on rust-lang#92360~ ~Based on rust-lang#93118~ There's a decent description in rust-lang#71827 that I won't copy here (for now at least) In addition to rebasing, I've tried to restore most of the original suggestions for invalid arguments. Unfortunately, this does make some of the errors a bit verbose. To fix this will require a bit of refactoring to some of the generalized error suggestion functions, and I just don't have the time to go into it right now. I think this is in a state that the error messages are overall better than before without a reduction in the suggestions given. ~I've tried to split out some of the easier and self-contained changes into separate commits (mostly in rust-lang#92360, but also one here). There might be more than can be done here, but again just lacking time.~ r? `@estebank` as the original reviewer of rust-lang#71827
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out in ways from my rebase/continuation of #71827
Commits are mostly self-explanatory and these changes should be fairly straightforward