Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add try_reserve and try_reserve_exact for OsString #92338

Merged
merged 7 commits into from
Jan 1, 2022
Merged

Add try_reserve and try_reserve_exact for OsString #92338

merged 7 commits into from
Jan 1, 2022

Commits on Dec 28, 2021

  1. Add try_reserve for OsString 

    Signed-off-by: Xuanwo <github@xuanwo.io>
    @Xuanwo
    Xuanwo committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    c40ac57 View commit details
    Browse the repository at this point in the history

  2. Fix windows build 

    Signed-off-by: Xuanwo <github@xuanwo.io>
    @Xuanwo
    Xuanwo committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    013fbc6 View commit details
    Browse the repository at this point in the history

  3. Implement support in wtf8 

    Signed-off-by: Xuanwo <github@xuanwo.io>
    @Xuanwo
    Xuanwo committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    27b92c9 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2021

  1. Update library/std/src/ffi/os_str.rs 

    Co-authored-by: David Tolnay <dtolnay@gmail.com>
    @Xuanwo @dtolnay
    Xuanwo and dtolnay authored Dec 29, 2021
    Configuration menu
    Copy the full SHA
    9166428 View commit details
    Browse the repository at this point in the history

  2. Address comments 

    Signed-off-by: Xuanwo <github@xuanwo.io>
    @Xuanwo
    Xuanwo committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    b07ae1c View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2021

  1. Fix some copy/paste hysteresis in OsString try_reserve docs 

    It appears `find_max_slow` comes from the BinaryHeap docs, where the
try_reserve example is a slow implementation of find_max. It has no
relevance to this code in OsString though.
    @dtolnay
    dtolnay committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    1f62c24 View commit details
    Browse the repository at this point in the history

  2. Remove needless allocation from example code of OsString

    @dtolnay
    dtolnay committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    d29941e View commit details
    Browse the repository at this point in the history