Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce compile time of rustbuild #92297

Merged
merged 5 commits into from
Jan 2, 2022
Merged

Reduce compile time of rustbuild #92297

merged 5 commits into from
Jan 2, 2022

Commits on Jan 1, 2022

  1. Remove the lazy_static dependency from rustbuild 

    Rustbuild already depends on once_cell which in the future can be
replaced with std::lazy::Lazy.
    @bjorn3
    bjorn3 committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    2fe2728 View commit details
    Browse the repository at this point in the history

  2. Avoid the merge derive macro in rustbuild 

    The task of the macro is simple enough that a decl macro is almost ten
times shorter than the original proc macro. The proc macro is 159 lines
while the decl macro is just 18 lines.

This reduces the amount of dependencies of rustbuild from 45 to 37. It
also slight reduces compilation time from 47s to 44s for debug builds.
    @bjorn3
    bjorn3 committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    043745c View commit details
    Browse the repository at this point in the history

  3. Make the rustc and rustdoc wrapper not depend on libbootstrap 

    This slightly improves compilation time by reducing linking time
(saving about a 1/10 of the the total compilation time after
changing rustbuild) and slightly reduces disk usage (from 16MB for
the rustc wrapper to 4MB).
    @bjorn3
    bjorn3 committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    947e948 View commit details
    Browse the repository at this point in the history

  4. Remove the merge dependency

    @bjorn3
    bjorn3 committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    ad6f98c View commit details
    Browse the repository at this point in the history

  5. Remove some dead code

    @bjorn3
    bjorn3 committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    7ea6e71 View commit details
    Browse the repository at this point in the history