Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #91937

Closed
wants to merge 18 commits into from

Commits on Dec 1, 2021

  1. Configuration menu
    Copy the full SHA
    911736d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dc18d50 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2021

  1. Revert "Set MACOSX_DEPLOYMENT_TARGET env var to default for linking i…

    …f not set."
    
    This reverts commit b376f56, which is
    the main part of rust-lang#90499, because it turns out that this causes a good
    amount of breakage in crates relying on the old behavior.
    
    Fixes rust-lang#91372.
    hkratz committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    3011154 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2021

  1. Configuration menu
    Copy the full SHA
    ae21dd0 View commit details
    Browse the repository at this point in the history
  2. Remove in_band_lifetimes from rustc_symbol_mangling

    Sylvan Bowdler committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    b682dec View commit details
    Browse the repository at this point in the history
  3. Remove in_band_lifetimes from rustc_trait_selection

    Sylvan Bowdler committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    1ea756b View commit details
    Browse the repository at this point in the history
  4. made compiler happy

    lameferret committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    90aa8fb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    97e844a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a586e7d View commit details
    Browse the repository at this point in the history
  7. Remove in_band_lifetimes from rustc_codegen_llvm

    See rust-lang#91867 for more information.
    LegionMammal978 committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    462bb57 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#91439 - ecstatic-morse:const-cmp-trait-defa…

    …ult-methods, r=oli-obk
    
    Mark defaulted `PartialEq`/`PartialOrd` methods as const
    
    WIthout it, `const` impls of these traits are unpleasant to write. I think this kind of change is allowed now. although it looks like it might require some Miri tweaks. Let's find out.
    
    r? `@fee1-dead`
    matthiaskrgr authored Dec 14, 2021
    Configuration menu
    Copy the full SHA
    af27a43 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#91870 - rusticstuff:macosx_min_version_reve…

    …rt, r=Mark-Simulacrum
    
    Revert setting a default for the MACOSX_DEPLOYMENT_TARGET env var for linking
    
    This reverts commit b376f56, which is the main part of rust-lang#90499, because it turns out that this causes a good amount of breakage in crates relying on the old behavior. In particular `winit`, `coreaudio` and crates that depend on them are affected. Fixes rust-lang#91372.
    
    Background:
    Before rust-lang#90499 the behavior was the following: If MACOSX_DEPLOYMENT_TARGET is not set,  we pass the minimum supported OS version to LLVM but not to the linker. The linker default depends on the Xcode version and the version of the OS it is running on. That caused one known problem in libcurl with the most recent Xcode versions. rust-lang#90499 passed the minumum supported version (10.7 for Macos x86-64) to the linker instead. This has shown to be problematic because some crates such as winit, coreaudio implicitly expect a newer minimum OS version. The libcurl issue has been fixed independently (see alexcrichton/curl-rust#417), so a revert should not really be problematic.
    
    Eventually we should probably mimic clang's behavior and fall back to the default of the currently configured Macos SDK for both the LLVM min os target version and MACOSX_DEPLOYMENT_TARGET for linking. That would entail looking at the `Version` property of the `SDKSettings.json` in the currently configured SDK.
    matthiaskrgr authored Dec 14, 2021
    Configuration menu
    Copy the full SHA
    93e6b90 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#91880 - matthiaskrgr:clippy_perf_dec, r=jyn514

    fix clippy::single_char_pattern perf findings
    matthiaskrgr authored Dec 14, 2021
    Configuration menu
    Copy the full SHA
    af11c6f View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#91882 - Patrick-Poitras:remove-in-band-life…

    …times-from-rustc-typeck, r=jackh726
    
    Remove `in_band_lifetimes` from `rustc_typeck`
    
    Joining in on the effort to remove the `in_band_lifetimes` features, as described in issue rust-lang#91867.
    matthiaskrgr authored Dec 14, 2021
    Configuration menu
    Copy the full SHA
    f5af398 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#91901 - SylvanB:remove_in_band_lifetimes_ru…

    …stc_symbol_mangling, r=jackh726
    
    Remove `in_band_lifetimes` from `rustc_symbol_mangling`
    
    Helping out with  rust-lang#91867
    matthiaskrgr authored Dec 14, 2021
    Configuration menu
    Copy the full SHA
    201f391 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#91904 - SylvanB:remove_in_band_lifetimes_ru…

    …stc_trait_selection, r=petrochenkov
    
    Remove `in_band_lifetimes` from `rustc_trait_selection`
    
    Another one for rust-lang#91867
    matthiaskrgr authored Dec 14, 2021
    Configuration menu
    Copy the full SHA
    0847115 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#91906 - anuvratsingh:remove_in_band_lifetim…

    …es_library_proc_macro, r=petrochenkov
    
    Removed `in_band_lifetimes` from `library\proc_macro`
    
    Issue [rust-lang#91867](rust-lang#91867)
    
    This is my first try, I followed the instructions given. Fixed all the errors that were thrown while compiling.
    Compiled with stage 0,1, and 2 all of them compiled successfully.
    matthiaskrgr authored Dec 14, 2021
    Configuration menu
    Copy the full SHA
    4750924 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#91931 - LegionMammal978:less-inband-codegen…

    …_llvm, r=davidtwco
    
    Remove `in_band_lifetimes` from `rustc_codegen_llvm`
    
    See rust-lang#91867 for more information.
    
    This one took a while. This crate has dozens of functions not associated with any type, and most of them were using in-band lifetimes for `'ll` and `'tcx`.
    matthiaskrgr authored Dec 14, 2021
    Configuration menu
    Copy the full SHA
    fb33c2b View commit details
    Browse the repository at this point in the history