Stabilize iter::zip
#91881
Merged
Stabilize iter::zip
#91881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
Mark-Simulacrum
removed
the
T-compiler
jyn514
added
T-libs-api
jyn514
approved these changes
Dec 14, 2021
rustbot
added
the
T-compiler
|
@workingjubilee I have undid those changes and then redid them. I don't know if that helps you at all, please let me know if it doesn't. |
|
☔ The latest upstream changes (presumably #91902) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@Patrick-Poitras can you squash the first two commits together? That way the only commit modifying clippy is the last one. https://rustc-dev-guide.rust-lang.org/git.html#advanced-rebasing |
camelid
removed
the
T-compiler
rustbot
added
the
T-compiler
Patrick-Poitras
force-pushed
the
stabilize-iter-zip
branch
from
7214497 to
a1c3189
Compare
|
@jyn514 done! Thanks to @cuviper and @wesleywiser on Zulip for helping me out when I messed up the merging! |
scottmcm
reviewed
Dec 14, 2021
scottmcm
added
the
relnotes
Patrick-Poitras
force-pushed
the
stabilize-iter-zip
branch
from
a1c3189 to
b94d89f
Compare
rustbot
added
the
T-rustdoc
Patrick-Poitras
force-pushed
the
stabilize-iter-zip
branch
3 times, most recently
from
decef6d to
016ee5f
Compare
This comment has been minimized.
This comment has been minimized.
Patrick-Poitras
force-pushed
the
stabilize-iter-zip
branch
from
016ee5f to
4665827
Compare
Patrick-Poitras
force-pushed
the
stabilize-iter-zip
branch
from
4665827 to
047adb5
Compare
inquisitivecrystal
removed
T-rustdoc
|
Thanks for the PR, @Patrick-Poitras! Sorry it was so 😬 |
|
📌 Commit 047adb5 has been approved by |
bors
added
S-waiting-on-bors
3 tasks
3 tasks
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 15, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#90939 (Tweak errors coming from `for`-loop, `?` and `.await` desugaring) - rust-lang#91859 (Iterator::cycle() — document empty iterator special case) - rust-lang#91868 (Use `OutputFilenames` to generate output file for `-Zllvm-time-trace`) - rust-lang#91870 (Revert setting a default for the MACOSX_DEPLOYMENT_TARGET env var for linking) - rust-lang#91881 (Stabilize `iter::zip`) - rust-lang#91882 (Remove `in_band_lifetimes` from `rustc_typeck`) - rust-lang#91940 (Update cargo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 17, 2021
… r=scottmcm Stabilize `iter::zip` Hello all! As the tracking issue (rust-lang#83574) for `iter::zip` completed the final commenting period without any concerns being raised, I hereby submit this stabilization PR on the issue. As the pull request that introduced the feature (rust-lang#82917) states, the `iter::zip` function is a shorter way to zip two iterators. As it's generally a quality-of-life/ergonomic improvement, it has been integrated into the codebase without any trouble, and has been used in many places across the rust compiler and standard library since March without any issues. For more details, I would refer to `@cuviper's` original PR, or the [function's documentation](https://doc.rust-lang.org/std/iter/fn.zip.html).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello all!
As the tracking issue (#83574) for
iter::zipcompleted the final commenting period without any concerns being raised, I hereby submit this stabilization PR on the issue.As the pull request that introduced the feature (#82917) states, the
iter::zipfunction is a shorter way to zip two iterators. As it's generally a quality-of-life/ergonomic improvement, it has been integrated into the codebase without any trouble, and has beenused in many places across the rust compiler and standard library since March without any issues.
For more details, I would refer to @cuviper's original PR, or the function's documentation.