Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core::ops::unsize: improve docs for DispatchFromDyn #91587

Merged
merged 1 commit into from
Jan 5, 2022
Merged

core::ops::unsize: improve docs for DispatchFromDyn #91587

merged 1 commit into from
Jan 5, 2022

Conversation

nrc
Copy link
Member

@nrc nrc commented Dec 6, 2021

Docs-only PR, improves documentation for DispatchFromDyn.

@nrc nrc added A-DSTs Area: Dynamically-sized types (DSTs) A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools F-dispatch_from_dyn `#![feature(dispatch_from_dyn)]` T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 6, 2021
@rust-highfive
Copy link
Collaborator

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 6, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nrc
Copy link
Member Author

nrc commented Dec 7, 2021

The WF-ness properties are enforced in https://github.com/rust-lang/rust/blob/master/compiler/rustc_typeck/src/coherence/builtin.rs#L121

@nrc
core::ops::unsize: improve docs for DispatchFromDyn
b3573c5 
Signed-off-by: Nick Cameron <nrc@ncameron.org>
@nrc
Copy link
Member Author

nrc commented Dec 24, 2021

ping @rust-lang/libs could I get a review please? Docs changes only.

@yaahc
Copy link
Member

yaahc commented Jan 4, 2022

Thank you @nrc!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 4, 2022

📌 Commit b3573c5 has been approved by yaahc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 4, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 4, 2022
@bors
Auto merge of rust-lang#92560 - matthiaskrgr:rollup-jeli7ip, r=matthi…
5883b87 
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#91587 (core::ops::unsize: improve docs for DispatchFromDyn)
 - rust-lang#91907 (Allow `_` as the length of array types and repeat expressions)
 - rust-lang#92515 (RustWrapper: adapt for an LLVM API change)
 - rust-lang#92516 (Do not use deprecated -Zsymbol-mangling-version in bootstrap)
 - rust-lang#92530 (Move `contains` method of Option and Result lower in docs)
 - rust-lang#92546 (Update books)
 - rust-lang#92551 (rename StackPopClean::None to Root)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d49c692 into rust-lang:master Jan 5, 2022
@rustbot rustbot added this to the 1.59.0 milestone Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-DSTs Area: Dynamically-sized types (DSTs) F-dispatch_from_dyn `#![feature(dispatch_from_dyn)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.
7 participants
@nrc @rust-highfive @rust-log-analyzer @yaahc @bors @m-ou-se @rustbot