Make IdFunctor::try_map_id panic-safe #91426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
eggyal
force-pushed
the
idfunctor-panic-safety
branch
from
403da27
to
51be4c7
Compare
This comment has been minimized.
This comment has been minimized.
|
squints "free(): double free detected in tcache 2" I think there's a bug here 😂 |
Aye, took me a while to spot it, but the assignment |
eggyal
force-pushed
the
idfunctor-panic-safety
branch
from
51be4c7
to
c471c6a
Compare
|
☔ The latest upstream changes (presumably #91318) made this pull request unmergeable. Please resolve the merge conflicts. |
eggyal
force-pushed
the
idfunctor-panic-safety
branch
from
c471c6a
to
026e155
Compare
|
this does look right to me, but stuff like that's scary, so if someone else from @rust-lang/compiler-contributors wants to look at this, please do ✨ if not, i am going to approve this in a few days |
nagisa
reviewed
Dec 5, 2021
eggyal
force-pushed
the
idfunctor-panic-safety
branch
from
026e155
to
acd39ff
Compare
apiraino
added
the
T-compiler
|
@bors r+ |
|
📌 Commit acd39ff has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 9, 2021
Make IdFunctor::try_map_id panic-safe Addresses FIXME comment created in rust-lang#78313 r? `@lcnr`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 10, 2021
Make IdFunctor::try_map_id panic-safe Addresses FIXME comment created in rust-lang#78313 r? ``@lcnr``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 11, 2021
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#91127 (Add `<*{const|mut} T>::{to|from}_bits`) - rust-lang#91310 (Add --out-dir flag for rustdoc) - rust-lang#91373 (Add needs-unwind to tests that depend on panicking) - rust-lang#91426 (Make IdFunctor::try_map_id panic-safe) - rust-lang#91515 (Add rsplit_array variants to slices and arrays) - rust-lang#91553 (socket ancillary data implementation for dragonflybsd.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses FIXME comment created in #78313
r? @lcnr