Do not visit attributes in ItemLowerer.
#91111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
cjgillot
force-pushed
the
hir-no-lower-attrs
branch
from
a48e333
to
9d39a6e
Compare
This comment has been minimized.
This comment has been minimized.
cjgillot
force-pushed
the
hir-no-lower-attrs
branch
from
9d39a6e
to
4404d4b
Compare
|
Hi, I run a fuzzer on this branch to make sure that it fixes all the crashes that I found, and it does fix them so that's nice. But I also found a new input that does crash on this branch: #![a={impl std::ops::Neg for i8 {}}]That doesn't ICE on latest nightly 2021-11-20, but it does ICE on stable 1.56.1. I guess it's the same issue, but if not then let me know and I will open a new one. Backtrace
|
apiraino
added
the
T-compiler
By default, AST visitors visit expressions that appear in key-value attributes. Those expressions should not be lowered to HIR, as they do not correspond to actually compiled code. Since an attribute cannot produce meaningful HIR, just skip them altogether.
cjgillot
force-pushed
the
hir-no-lower-attrs
branch
from
4404d4b
to
907a69d
Compare
This comment has been minimized.
This comment has been minimized.
cjgillot
force-pushed
the
hir-no-lower-attrs
branch
from
907a69d
to
7f5d3ff
Compare
|
@Badel2 this should fix your second example. |
|
📌 Commit 7f5d3ff has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 25, 2021
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#89359 (Various fixes for const_trait_impl) - rust-lang#90499 (Link with default MACOSX_DEPLOYMENT_TARGET if not otherwise specified.) - rust-lang#91096 (Print associated types on opaque `impl Trait` types) - rust-lang#91111 (Do not visit attributes in `ItemLowerer`.) - rust-lang#91162 (explain why CTFE/Miri perform truncation on shift offset) - rust-lang#91185 (Remove `-Z force-overflow-checks`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
Yes, this fixes all the examples I found. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, AST visitors visit expressions that appear in key-value attributes.
Those expressions should not be lowered to HIR, as they do not correspond to actually compiled code.
Since an attribute cannot produce meaningful HIR, just skip them altogether.
Fixes #81886
Fixes #90873
r? @michaelwoerister