Emit impl difference error for GenericBoundFailure too #89914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
jackh726
force-pushed
the
gat_genericboundfailure
branch
from
be886cd
to
c4f9eb1
Compare
estebank
reviewed
Oct 15, 2021
| LL | / type TRef<'a> | ||
| LL | | | ||
| LL | | | ||
| LL | | where | ||
| LL | | <Left as HasChildrenOf>::T: 'a, | ||
| LL | | <Right as HasChildrenOf>::T: 'a | ||
| | | - help: consider adding a where clause: `, <Left as HasChildrenOf>::T: 'a` |
There was a problem hiding this comment.
I was gonna say "I'm sad about the missing suggestion" but a glance shows that the suggestion was wrong in the first place :-/
There was a problem hiding this comment.
This pattern is unrepresentable even with GATs, right?
There was a problem hiding this comment.
Well, the suggested clause already exists, but even if it didn't, we can't have clauses on an impl that weren't there in the trait.
|
@bors r+ |
|
📌 Commit c4f9eb1 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 15, 2021
…=estebank Emit impl difference error for GenericBoundFailure too Fixes rust-lang#86787 r? `@estebank`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 15, 2021
…=estebank Emit impl difference error for GenericBoundFailure too Fixes rust-lang#86787 r? ``@estebank``
jackh726
added a commit
to jackh726/rust
that referenced
this pull request
Oct 16, 2021
…=estebank Emit impl difference error for GenericBoundFailure too Fixes rust-lang#86787 r? ```@estebank```
This was referenced Oct 16, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 16, 2021
…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#89509 (Stabilize `unreachable_unchecked` as `const fn`) - rust-lang#89898 (Remove alloc::prelude) - rust-lang#89902 (Restrict the aarch64 outline atomics test to Linux) - rust-lang#89906 (Moved format-version constant to rustdoc-json-types) - rust-lang#89912 (emitter: current substitution can be multi-line) - rust-lang#89914 (Emit impl difference error for GenericBoundFailure too) - rust-lang#89915 (Some outlives cleanup) - rust-lang#89918 (Add some GATs related regression tests) - rust-lang#89921 ([fuchsia] Update process info struct) - rust-lang#89925 (updating docs to mention usage of AtomicBool) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86787
r? @estebank