Cleanup LLVM multi-threading checks #89808
Conversation
The support for runtime multi-threading was removed from LLVM. Calls to `LLVMStartMultithreaded` became no-ops equivalent to checking if LLVM was compiled with support for threads http://reviews.llvm.org/D4216.
|
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @nagisa |
apiraino
added
the
T-compiler
| INIT.call_once(|| bug!("llvm is not initialized")); | ||
| if POISONED.load(Ordering::SeqCst) { | ||
| bug!("couldn't enable multi-threaded LLVM"); | ||
| if !INIT.is_completed() { |
There was a problem hiding this comment.
This is somewhat more racy than the previous version. Previously call_once would block if the confiugre_llvm from another call to init was already being executed.
There was a problem hiding this comment.
My thinking was that if there is a race, a thread executing require_inited might win and this would indicate a presence of a bug that needs to be fixed regardless.
|
Seems good overall. r=me after |
|
@bors r+ |
|
📌 Commit aa3bf01 has been approved by |
bors
added
S-waiting-on-bors
Cleanup LLVM multi-threading checks The support for runtime multi-threading was removed from LLVM. Calls to `LLVMStartMultithreaded` became no-ops equivalent to checking if LLVM was compiled with support for threads http://reviews.llvm.org/D4216.
Cleanup LLVM multi-threading checks The support for runtime multi-threading was removed from LLVM. Calls to `LLVMStartMultithreaded` became no-ops equivalent to checking if LLVM was compiled with support for threads http://reviews.llvm.org/D4216.
Cleanup LLVM multi-threading checks The support for runtime multi-threading was removed from LLVM. Calls to `LLVMStartMultithreaded` became no-ops equivalent to checking if LLVM was compiled with support for threads http://reviews.llvm.org/D4216.
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (56694b0): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
8 participants
The support for runtime multi-threading was removed from LLVM. Calls to
LLVMStartMultithreadedbecame no-ops equivalent to checking if LLVMwas compiled with support for threads http://reviews.llvm.org/D4216.