Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ABNF of inline asm options #89713

Merged
merged 1 commit into from
Oct 10, 2021
Merged

Fix ABNF of inline asm options #89713

merged 1 commit into from
Oct 10, 2021

Conversation

nbdd0121
Copy link
Contributor

@nbdd0121 nbdd0121 commented Oct 9, 2021

This is the case since #73227.

r? @camelid

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2021
@camelid
Copy link
Member

camelid commented Oct 9, 2021

This LGTM, but I'll r? @Amanieu since I haven't worked on inline assembly in a while.

@rust-highfive rust-highfive assigned Amanieu and unassigned camelid Oct 9, 2021
@camelid camelid added A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-inline-assembly Area: Inline assembly (`asm!(…)`) F-asm `#![feature(asm)]` (not `llvm_asm`) labels Oct 9, 2021
@Amanieu
Copy link
Member

Amanieu commented Oct 10, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 10, 2021

📌 Commit 7b5bedf has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2021
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 10, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 10, 2021
@bors
Auto merge of rust-lang#89739 - matthiaskrgr:rollup-kskwqy5, r=matthi…
41dfaaa 
…askrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#88374 (Fix documentation in Cell)
 - rust-lang#88713 (Improve docs for int_log)
 - rust-lang#89428 (Feature gate the non_exhaustive_omitted_patterns lint)
 - rust-lang#89438 (docs: `std::hash::Hash` should ensure prefix-free data)
 - rust-lang#89520 (Don't rebuild GUI test crates every time you run test src/test/rustdoc-gui)
 - rust-lang#89705 (Cfg hide no_global_oom_handling and no_fp_fmt_parse)
 - rust-lang#89713 (Fix ABNF of inline asm options)
 - rust-lang#89718 (Add #[must_use] to is_condition tests)
 - rust-lang#89719 (Add #[must_use] to char escape methods)
 - rust-lang#89720 (Add #[must_use] to math and bit manipulation methods)
 - rust-lang#89735 (Stabilize proc_macro::is_available)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8aec76c into rust-lang:master Oct 10, 2021
@rustbot rustbot added this to the 1.57.0 milestone Oct 10, 2021
@nbdd0121 nbdd0121 deleted the doc2 branch October 10, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelid camelid camelid approved these changes

Assignees

@Amanieu Amanieu

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-inline-assembly Area: Inline assembly (`asm!(…)`) F-asm `#![feature(asm)]` (not `llvm_asm`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.57.0
Development

Successfully merging this pull request may close these issues.
6 participants
@nbdd0121 @camelid @Amanieu @bors @rust-highfive @rustbot