Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include copies of rust-lld for -Z gcc-ld=lld only in nightly builds. #89218

Closed
wants to merge 1 commit into from
Closed

Include copies of rust-lld for -Z gcc-ld=lld only in nightly builds. #89218

wants to merge 1 commit into from

Conversation

hkratz
Copy link
Contributor

@hkratz hkratz commented Sep 24, 2021 •
edited
Loading

Takes care of #88869 for beta/future stable.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 24, 2021
@klensy
Copy link
Contributor

klensy commented Sep 25, 2021 •
edited
Loading

We can ignore that this will break things with RUSTC_BOOTSTRAP (for -Z gcc-ld) on beta\stable?

@hkratz
Copy link
Contributor Author

hkratz commented Sep 26, 2021

Closing in favor of #89288.

@hkratz hkratz closed this Sep 26, 2021
@hkratz hkratz deleted the include_lld_copies_only_on_nightly branch November 27, 2021 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hkratz @rust-highfive @klensy @Mark-Simulacrum