Commits on Sep 16, 2021

1. Fix linting when trailing macro expands to a trailing semi …

   When a macro is used in the trailing expression position of a block
   (e.g. `fn foo() { my_macro!() }`), we currently parse it as an
   expression, rather than a statement. As a result, we ended up
   using the `NodeId` of the containing statement as our `lint_node_id`,
   even though we don't normally do this for macro calls.
   
   If such a macro expands to an expression with a `#[cfg]` attribute,
   then the trailing statement can get removed entirely. This lead to
   an ICE, since we were usng the `NodeId` of the expression to emit
   a lint.
   
   Ths commit makes us skip updating `lint_node_id` when handling
   a macro in trailing expression position. This will cause us to
   lint at the closest parent of the macro call.

   

   Aaron1011 committed Sep 16, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for bd4c967
   • Browse repository at this point

   Copy the full SHA

   bd4c967 View commit details

   Browse the repository at this point in the history