- 
                Notifications
    
You must be signed in to change notification settings  - Fork 13.9k
 
Fix implementors display #87035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            bors
  merged 3 commits into
  rust-lang:master
from
GuillaumeGomez:fix-implementors-display
  
      
      
   
  Jul 13, 2021 
      
    
                
     Merged
            
            Fix implementors display #87035
                    bors
  merged 3 commits into
  rust-lang:master
from
GuillaumeGomez:fix-implementors-display
  
      
      
   
  Jul 13, 2021 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
           Some changes occurred in HTML/CSS/JS.  | 
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
3009536    to
    3ec22f2      
    Compare
  
    | 
           And I forgot to format as usual...  | 
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
3ec22f2    to
    975e990      
    Compare
  
    
  This was referenced Jul 12, 2021 
      
| 
           cc @camelid  | 
    
              
                    notriddle
  
              
              approved these changes
              
                  
                    Jul 12, 2021 
                  
              
              
            
            
              
                    notriddle
  
              
              reviewed
              
                  
                    Jul 12, 2021 
                  
              
              
            
            
975e990    to
    bd81949      
    Compare
  
    | 
           @bors: r=notriddle  | 
    
| 
           📌 Commit bd81949 has been approved by   | 
    
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Jul 13, 2021 
    
    
      
  
    
      
    
  
Rollup of 11 pull requests Successful merges: - rust-lang#86344 (Split MaybeUninit::write into new feature gate and stabilize it) - rust-lang#86811 (Remove unstable `io::Cursor::remaining`) - rust-lang#86846 (stdio_locked: add tracking issue) - rust-lang#86887 (rustdoc: remove dead code in `clean`) - rust-lang#87007 (Fix rust-analyzer install when not available.) - rust-lang#87035 (Fix implementors display) - rust-lang#87065 (Fix ICE with unsized type in const pattern) - rust-lang#87070 (Simplify future incompatible reporting.) - rust-lang#87077 (:arrow_up: rust-analyzer) - rust-lang#87078 (Rustdoc: suggest removing disambiguator if linking to field) - rust-lang#87089 (CTFE engine: small cleanups) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    A-rustdoc-js
  Area: Rustdoc's JS front-end 
  
    A-rustdoc-ui
  Area: Rustdoc UI (generated HTML) 
  
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  
    T-rustdoc
  Relevant to the rustdoc team, which will review and decide on the PR/issue. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Part of #86632.
This PR does a few things:
Before:
After:
I plan to add the
[src]links in another PR because this one is already big enough.cc @Mark-Simulacrum (for the bootstrap changes)
r? @Nemo157