Skip to content

Conversation

fee1-dead
Copy link
Member

@fee1-dead fee1-dead commented Jun 30, 2021

This PR does two things:

  • Fixes metadata not encoded properly for functions in const trait impls.
  • Adds tests for using const trait impls cross-crate with the feature gate on the user crate either enabled or disabled.

See #67792 for the tracking issue, cc @oli-obk

@rust-highfive
Copy link
Contributor

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 30, 2021
@jonas-schievink
Copy link
Contributor

Nice!

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 30, 2021

📌 Commit c424510 has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2021
@tmiasko
Copy link
Contributor

tmiasko commented Jun 30, 2021

This should fix #84846 and #83937.

@jackh726
Copy link
Member

r? @jonas-schievink

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 1, 2021
Rollup of 8 pull requests

Successful merges:

 - rust-lang#85504 (the foundation owns rust trademarks)
 - rust-lang#85520 (Fix typo and improve documentation for E0632)
 - rust-lang#86680 (Improve error for missing -Z with debugging option)
 - rust-lang#86728 (Check node kind to avoid ICE in `check_expr_return()`)
 - rust-lang#86740 (copy rust-lld as ld in dist)
 - rust-lang#86746 (Fix rustdoc query type filter)
 - rust-lang#86750 (Test cross-crate usage of `feature(const_trait_impl)`)
 - rust-lang#86755 (alloc: `RawVec<T, A>::shrink` can be in `no_global_oom_handling`.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7714a9a into rust-lang:master Jul 1, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants