Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #86373

Closed
wants to merge 26 commits into from

Commits on May 12, 2021

  1. Added the --temps-dir option.

    Tor Hovland committed May 12, 2021
    Configuration menu
    Copy the full SHA
    4191853 View commit details
    Browse the repository at this point in the history
  2. Create temps_dir before it's needed.

    Tor Hovland committed May 12, 2021
    Configuration menu
    Copy the full SHA
    c0e8578 View commit details
    Browse the repository at this point in the history
  3. Emitted files go to the output dir.

    Tor Hovland committed May 12, 2021
    Configuration menu
    Copy the full SHA
    abf9653 View commit details
    Browse the repository at this point in the history
  4. Documentation.

    Tor Hovland committed May 12, 2021
    Configuration menu
    Copy the full SHA
    e146192 View commit details
    Browse the repository at this point in the history
  5. Fix test.

    Tor Hovland committed May 12, 2021
    Configuration menu
    Copy the full SHA
    9a60e47 View commit details
    Browse the repository at this point in the history
  6. Added a regression test.

    Tor Hovland committed May 12, 2021
    Configuration menu
    Copy the full SHA
    857b19d View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2021

  1. Configuration menu
    Copy the full SHA
    14f3ec2 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2021

  1. Link reference in dyn keyword documentation

    The "read more" sentence formatted "object safety" as inline code
    instead of providing a link to more information.  This PR adds a link
    to the Reference about this matter, as well as the page regarding trait
    objects.
    amorison committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    7728476 View commit details
    Browse the repository at this point in the history
  2. Mention the Borrow guarantee on the Hash implementations for Array an…

    …d Vec
    
    To remind people like me who forget about it and send PRs to make them different, and to (probably) get a test failure if the code is changed to no longer uphold it.
    scottmcm committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    3802d57 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2021

  1. Configuration menu
    Copy the full SHA
    78df1b8 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2021

  1. Configuration menu
    Copy the full SHA
    c8a8a23 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    280d193 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d828ead View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fb06d9e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a2a006d View commit details
    Browse the repository at this point in the history
  6. Typo correction: s/is/its

    snoyberg authored Jun 16, 2021
    Configuration menu
    Copy the full SHA
    770e8cc View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#83846 - torhovland:issue-10971, r=davidtwco

    Added the --temps-dir option
    
    Fixes rust-lang#10971.
    
    The new `--temps-dir` option puts intermediate files in a user-specified directory. This provides a fix for the issue where parallel invocations of rustc would overwrite each other's intermediate files.
    
    No files are kept in the intermediate directory unless `-C save-temps=yes`.
    
    If additional files are specifically requested using `--emit asm,llvm-bc,llvm-ir,obj,metadata,link,dep-info,mir`, these will be put in the output directory rather than the intermediate directory.
    
    This is a backward-compatible change, i.e. if `--temps-dir` is not specified, the behavior is the same as before.
    GuillaumeGomez authored Jun 16, 2021
    Configuration menu
    Copy the full SHA
    2d097c1 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#86104 - FabianWolff:issue-86085, r=davidtwco

    Fix span calculation in format strings
    
    This pull request fixes rust-lang#86085. The ICE described there is due to an error in the span calculation inside format strings, if the format string is the result of a macro invocation:
    ```rust
    fn main() {
        format!(concat!("abc}"));
    }
    ```
    currently produces:
    ```
    error: invalid format string: unmatched `}` found
     --> test.rs:2:17
      |
    2 |     format!(concat!("abc}"));
      |                 ^ unmatched `}` in format string
    ```
    which is obviously incorrect. This happens because the span of the entire `concat!()` is combined with the _relative_ location of the unmatched `` `}` `` in the _result_ of the macro invocation (i.e. 4).
    
    In rust-lang#86085, this has led to a span that starts or ends in the middle of a multibyte character, but the root cause was the same. This pull request fixes the problem.
    GuillaumeGomez authored Jun 16, 2021
    Configuration menu
    Copy the full SHA
    a0839b4 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#86140 - scottmcm:array-hash-facepalm, r=ken…

    …nytm
    
    Mention the `Borrow` guarantee on the `Hash` implementations for Arrays and `Vec`
    
    To remind people like me who forget about it and send PRs to make them different, and to (probably) get a test failure if the code is changed to no longer uphold it.
    GuillaumeGomez authored Jun 16, 2021
    Configuration menu
    Copy the full SHA
    bf53ee1 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#86141 - amorison:link-ref-in-doc-dyn-keywor…

    …d, r=kennytm
    
    Link reference in `dyn` keyword documentation
    
    The "read more" sentence formatted "object safety" as inline code
    instead of providing a link to more information.  This PR adds a link
    to the Reference about this matter, as well as the page regarding trait
    objects.
    
    ---
    
    We could also put these links in the very first line (instead of the link to the
    Book) and in the first paragraph which mentions the "object safe" requirement.
    Personally, I think it's good to keep the link to the Book up-front as it's more
    accessible than the Reference.
    GuillaumeGomez authored Jun 16, 2021
    Configuration menu
    Copy the full SHA
    cb7fbfa View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#86339 - JohnTitor:note-derive-on-proc-macro…

    …s, r=petrochenkov
    
    Mention rust-lang#79078 on compatibility notes of 1.52
    
    Closes rust-lang#85854
    r? `@petrochenkov`
    GuillaumeGomez authored Jun 16, 2021
    Configuration menu
    Copy the full SHA
    8d91f98 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#86343 - JohnTitor:issue-85581, r=estebank

    Do not emit invalid suggestions on multiple mutable borrow errors
    
    Fixes rust-lang#85581
    GuillaumeGomez authored Jun 16, 2021
    Configuration menu
    Copy the full SHA
    cae088d View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#86353 - JohnTitor:remove-projection_ty_from…

    …_predicates, r=oli-obk
    
    Remove `projection_ty_from_predicates`
    
    Fixes rust-lang#86350
    r? `@oli-obk`
    GuillaumeGomez authored Jun 16, 2021
    Configuration menu
    Copy the full SHA
    3f457a2 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#86355 - JohnTitor:issue-82158, r=estebank

    Remove invalid suggestions for assoc consts on placeholder type error
    
    Fixes rust-lang#82158
    This also moves some tests to typeck.
    r? `@estebank`
    GuillaumeGomez authored Jun 16, 2021
    Configuration menu
    Copy the full SHA
    0f0eff9 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#86361 - GuillaumeGomez:missing-backslashes,…

    … r=jsha
    
    Add missing backslashes to prevent unwanted backlines in rustdoc HTML
    
    Just adding some forgotten backslashes.
    
    r? `@jsha`
    GuillaumeGomez authored Jun 16, 2021
    Configuration menu
    Copy the full SHA
    bc14e69 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#86372 - snoyberg:patch-1, r=jonas-schievink

    Typo correction: s/is/its
    GuillaumeGomez authored Jun 16, 2021
    Configuration menu
    Copy the full SHA
    fb4fb21 View commit details
    Browse the repository at this point in the history