Fix auto-hide for implementations and implementors. #85575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Also, that be nice to have a GUI test to enforce it. I can write it if you want (so then we merge this PR directly and open an issue), as your prefer. |
|
If you could write the GUI test I'd appreciate it. I haven't yet learned how to make those. I'll need to learn, but I'd also like to get this regression fixed quick-ish. :-) |
This sets their toggles to be closed in the HTML (matching the default setting), and opens them if the setting indicates to do so. This distinguishes between implementations and implementors based on being descendants of certain named elements.
|
Then please open an issue for it. Once done, you can r=me this PR. ;) |
|
📌 Commit 5ebbed6 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 23, 2021
Rollup of 6 pull requests Successful merges: - rust-lang#84758 (MSVC: Avoid using jmp stubs for dll function imports) - rust-lang#85288 (add an example to explain std::io::Read::read returning 0 in some cases) - rust-lang#85334 (Add doc aliases to `unit`) - rust-lang#85525 (Fix my mailmap entry) - rust-lang#85571 (Remove surplus prepend LinkedList fn) - rust-lang#85575 (Fix auto-hide for implementations and implementors.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
Actually, it broke something. I can't wait for #84586 to be finally merged. T_T Sending a fix... |
GuillaumeGomez
added
T-rustdoc
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 23, 2021
…s, r=jsha Don't hide inherent implementations by default Fixes a regression introduced in rust-lang#85575. r? `@jsha`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets their toggles to be closed in the HTML (matching the default
setting), and opens them if the setting indicates to do so.
This distinguishes between implementations and implementors based on
being descendants of certain named elements.
Demo https://hoffman-andrews.com/rust/fix-toggle-settings/std/io/trait.Read.html#implementors
and https://hoffman-andrews.com/rust/fix-toggle-settings/std/string/struct.String.html#trait-implementations
Fixes #85411
r? @GuillaumeGomez