Provide io::Seek::rewind #85146
Merged
Provide io::Seek::rewind #85146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
|
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
m-ou-se
reviewed
May 10, 2021
There was a problem hiding this comment.
Looks reasonable to me. Can you open a tracking issue? Thanks!
Co-authored-by: Mara Bos <m-ou.se@m-ou.se>
3 tasks
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
jackh726
reviewed
May 10, 2021
|
@bors r+ |
|
📌 Commit 7ae852e has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 10, 2021
Rollup of 6 pull requests Successful merges: - rust-lang#85050 (Fix suggestions for missing return type lifetime specifiers) - rust-lang#85075 (Improve "panic message is not a string literal" warning) - rust-lang#85096 (Make unchecked_{add,sub,mul} inherent methods unstably const) - rust-lang#85112 (ensure failing promoteds in const/static bodies are handled correctly) - rust-lang#85146 (Provide io::Seek::rewind) - rust-lang#85147 (:arrow_up: rust-analyzer) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
Seek::seekis slightly clumsy because of the need to write (or import)std::io::SeekFromto get atSeekStart. C already hasrewind(although with broken error handling); we should have it too.I'm motivated to do this because I've just found myself copy-pasting my 5-line extension trait between projects.
That the example ends up using
OpenOptionsmakes this look like a niche use case, but it is very common to rewind temporary files.tempfileisn't available for use in this example or it would have looked shorter and more natural.If this gets a positive reception I will open a tracking issue and update the feature gate.